Rollup of 4 pull requests #146043

tgross35 · 2025-08-30T23:49:50Z

Successful merges:

std: clarify OpenOptions error for create without write access #144964 (std: clarify OpenOptions error for create without write access)
Fix sys::process::windows::tests::test_thread_handle spurious failure #146030 (Fix sys::process::windows::tests::test_thread_handle spurious failure)
Update browser-ui-test version to 0.21.3 #146035 (Update browser-ui-test version to 0.21.3)
Use move_file for rename in tracing #146036 (Use move_file for rename in tracing)

r? @ghost
@rustbot modify labels: rollup

Previously, attempting to create/truncate a file without write/append access would result in platform-specific error messages: - Unix: "Invalid argument" - Windows: raw OS error code 87 These error codes look like system errors, which could waste hours of debugging for what is actually an API misuse issue.

This avoids panicking when the source and destinations are on different filesystems.

…aheemdev std: clarify `OpenOptions` error for create without write access Fixes rust-lang#140621

Fix `sys::process::windows::tests::test_thread_handle` spurious failure Instead of sleeping, wait for the process to finish so that we can be sure it's done. We use a timeout because otherwise this test can be stuck indefinitely if it fails (unfortunately std doesn't currently have a way to wait with a timeout so a manual OS API call is necessary). I also changed the test to run `whoami` and pipe the output to null so that it doesn't clutter up the test output. Fixes rust-lang#146024

…est, r=GuillaumeGomez Update `browser-ui-test` version to `0.21.3` I cannot test it locally because of this bug: ``` error: couldn't generate documentation: failed to read column from disk: data consumer error: missing field `unknown number` at line 1 column 8 | = note: failed to create or modify "build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/search.index/entry/": failed to read column from disk: data consumer error: missing field `unknown number` at line 1 column 8 ``` So I'll iterate through CI checks I guess. r? ghost

Use move_file for rename in tracing This avoids panicking when the source and destination are on different filesystems.

tgross35 · 2025-08-30T23:50:00Z

@bors r+ rollup=never p=5

bors · 2025-08-30T23:50:02Z

📌 Commit 7185ec6 has been approved by tgross35

It is now in the queue for this repository.

bors · 2025-08-30T23:51:32Z

⌛ Testing commit 7185ec6 with merge cd60c60...

bors · 2025-08-31T02:59:46Z

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing cd60c60 to master...

rust-timer · 2025-08-31T03:00:55Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#144964	std: clarify `OpenOptions` error for create without write a…	`5f17c1d5dcaa0f1c7c3da708396215fbcb135a6a` (link)
#146030	Fix `sys::process::windows::tests::test_thread_handle` spur…	`b4b59428831ca8008ca385bc4748b05619b99bd7` (link)
#146035	Update `browser-ui-test` version to `0.21.3`	`a7dd89a35710204bb6aa7f9ed2e9850a434cc6cd` (link)
#146036	Use move_file for rename in tracing	`d3e30a1764c59b131cfcdbf8976319c908e9bb98` (link)

previous master: 523d3999dc

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-08-31T03:03:02Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 523d399 (parent) -> cd60c60 (this PR)

Test differences

Show 87 test diffs

Stage 1

fs::tests::test_open_options_invalid_combinations: [missing] -> pass (J0)

Additionally, 86 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-gnu-nopt-2, i686-msvc-1, pr-check-2, test-various, x86_64-gnu, x86_64-gnu-llvm-19-2, x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cd60c60d9f6bf13ca96ecde7392327c3caf6f162 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 6175.0s -> 9040.3s (46.4%)
aarch64-apple: 5428.7s -> 6902.0s (27.1%)
pr-check-1: 1464.6s -> 1359.6s (-7.2%)
x86_64-gnu-llvm-19: 2609.2s -> 2432.2s (-6.8%)
aarch64-gnu-llvm-19-1: 3670.9s -> 3442.0s (-6.2%)
dist-x86_64-windows-gnullvm: 5097.3s -> 4780.6s (-6.2%)
aarch64-gnu: 7357.8s -> 6924.0s (-5.9%)
x86_64-gnu-llvm-20-1: 3454.9s -> 3259.6s (-5.7%)
dist-aarch64-apple: 6735.0s -> 7104.0s (5.5%)
x86_64-mingw-2: 7679.8s -> 8044.9s (4.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-31T04:09:27Z

Finished benchmarking commit (cd60c60): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	2
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 1.5%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Binary size

Results (primary 0.3%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.6%]	8
Regressions ❌ (secondary)	0.5%	[0.3%, 0.6%]	41
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.1%, 0.6%]	8

Bootstrap: 465.403s -> 466.008s (0.13%)
Artifact size: 388.58 MiB -> 388.55 MiB (-0.01%)

0xdeafbeef and others added 8 commits August 30, 2025 14:59

Update browser-ui-test version to 0.21.3

9e8d907

Use move_file for rename in tracing

2dc5752

This avoids panicking when the source and destinations are on different filesystems.

Fix spurious test timeout

3516e25

Rollup merge of rust-lang#144964 - 0xdeafbeef:fix-open-options, r=ibr…

9489339

…aheemdev std: clarify `OpenOptions` error for create without write access Fixes rust-lang#140621

Rollup merge of rust-lang#146036 - Mark-Simulacrum:rust-1, r=Kobzol

7185ec6

Use move_file for rename in tracing This avoids panicking when the source and destination are on different filesystems.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 31, 2025

bors merged commit cd60c60 into rust-lang:master Aug 31, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 31, 2025

bors mentioned this pull request Aug 31, 2025

dirfd: preliminary unix and windows implementations #139514

Open

tgross35 deleted the rollup-hdumq5v branch August 31, 2025 05:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests #146043

Rollup of 4 pull requests #146043

Uh oh!

tgross35 commented Aug 30, 2025 •

edited by rustbot

Loading

Uh oh!

tgross35 commented Aug 30, 2025

Uh oh!

bors commented Aug 30, 2025

Uh oh!

bors commented Aug 30, 2025

Uh oh!

bors commented Aug 31, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Stage 1

Uh oh!

rust-timer commented Aug 31, 2025

Uh oh!

Uh oh!

Rollup of 4 pull requests #146043

Rollup of 4 pull requests #146043

Uh oh!

Conversation

tgross35 commented Aug 30, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Aug 30, 2025

Uh oh!

bors commented Aug 30, 2025

Uh oh!

bors commented Aug 30, 2025

Uh oh!

bors commented Aug 31, 2025

Uh oh!

Uh oh!

rust-timer commented Aug 31, 2025

Uh oh!

github-actions bot commented Aug 31, 2025

Test differences

Stage 1

Job duration changes

Uh oh!

rust-timer commented Aug 31, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

tgross35 commented Aug 30, 2025 •

edited by rustbot

Loading