compiletest: cygwin follows windows in using PATH for dynamic libraries #146140

jeremyd2019 · 2025-09-02T23:28:15Z

rustbot · 2025-09-02T23:28:19Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-09-02T23:28:21Z

Some changes occurred in src/tools/compiletest

cc @jieyouxu

jeremyd2019 · 2025-09-03T00:29:42Z

r? @jieyouxu

rustbot · 2025-09-03T00:29:46Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

jieyouxu

Thanks.

I can't really test this locally, so I am assuming it works for you locally (at worst we can simply revert).

View changes since this review

jieyouxu · 2025-09-03T00:46:07Z

@bors r+ rollup

bors · 2025-09-03T00:46:09Z

📌 Commit af0d6f1 has been approved by jieyouxu

It is now in the queue for this repository.

compiletest: cygwin follows windows in using PATH for dynamic libraries ``@Berrysoft``

compiletest: cygwin follows windows in using PATH for dynamic libraries ```@Berrysoft```

Rollup of 15 pull requests Successful merges: - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146120 (Correct typo in `rustc_errors` comment) - #146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - #146131 (rustdoc-search: add test case for indexing every item type) - #146133 (Revert "Make `lto` and `linker-plugin-lto` work the same for `compiler_builtins`) - #146134 (llvm: nvptx: Layout update to match LLVM) - #146136 (docs(std): add missing closing code block fences in doc comments) - #146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) r? `@ghost` `@rustbot` modify labels: rollup

compiletest: cygwin follows windows in using PATH for dynamic libraries ````@Berrysoft````

src/tools/compiletest/src/util.rs

Rollup of 16 pull requests Successful merges: - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145342 (fix drop scope for `super let` bindings within `if let`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146120 (Correct typo in `rustc_errors` comment) - #146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - #146133 (Revert "Make `lto` and `linker-plugin-lto` work the same for `compiler_builtins`) - #146134 (llvm: nvptx: Layout update to match LLVM) - #146136 (docs(std): add missing closing code block fences in doc comments) - #146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - #146156 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 24 pull requests Successful merges: - #140459 (Add `read_buf` equivalents for positioned reads) - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145342 (fix drop scope for `super let` bindings within `if let`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - #145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146112 (don't uppercase error messages) - #146120 (Correct typo in `rustc_errors` comment) - #146124 (Test `rustc-dev` in `distcheck`) - #146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - #146131 (rustdoc-search: add test case for indexing every item type) - #146134 (llvm: nvptx: Layout update to match LLVM) - #146136 (docs(std): add missing closing code block fences in doc comments) - #146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - #146150 (fix(rustdoc): match rustc `--emit` precedence ) - #146155 (Make bootstrap self test parallel) - #146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - #146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #146140 - jeremyd2019:patch-1, r=jieyouxu compiletest: cygwin follows windows in using PATH for dynamic libraries `@Berrysoft`

jeremyd2019 · 2025-09-04T18:13:06Z

Thanks.

I can't really test this locally, so I am assuming it works for you locally (at worst we can simply revert).

ui tests with 1.89.0 before this change:

test result: FAILED. 15060 passed; 3973 failed; 267 ignored; 0 measured; 0 filtered out; finished in 1213.10s

With this change applied to 1.89.0

test result: FAILED. 19003 passed; 30 failed; 267 ignored; 0 measured; 0 filtered out; finished in 1294.54s

Rollup of 24 pull requests Successful merges: - rust-lang/rust#140459 (Add `read_buf` equivalents for positioned reads) - rust-lang/rust#143725 (core: add Peekable::next_if_map) - rust-lang/rust#145209 (Stabilize `path_add_extension`) - rust-lang/rust#145342 (fix drop scope for `super let` bindings within `if let`) - rust-lang/rust#145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - rust-lang/rust#145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - rust-lang/rust#145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - rust-lang/rust#145962 (Ensure we emit an allocator shim when only some crate types need one) - rust-lang/rust#145963 (Add LSX accelerated implementation for source file analysis) - rust-lang/rust#146054 (add `#[must_use]` to `array::repeat`) - rust-lang/rust#146090 (Derive `PartialEq` for `InvisibleOrigin`) - rust-lang/rust#146112 (don't uppercase error messages) - rust-lang/rust#146120 (Correct typo in `rustc_errors` comment) - rust-lang/rust#146124 (Test `rustc-dev` in `distcheck`) - rust-lang/rust#146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - rust-lang/rust#146131 (rustdoc-search: add test case for indexing every item type) - rust-lang/rust#146134 (llvm: nvptx: Layout update to match LLVM) - rust-lang/rust#146136 (docs(std): add missing closing code block fences in doc comments) - rust-lang/rust#146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - rust-lang/rust#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - rust-lang/rust#146150 (fix(rustdoc): match rustc `--emit` precedence ) - rust-lang/rust#146155 (Make bootstrap self test parallel) - rust-lang/rust#146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - rust-lang/rust#146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

compiletest: cygwin follows windows in using PATH for dynamic libraries

af0d6f1

rustbot assigned Mark-Simulacrum Sep 2, 2025

rustbot assigned jieyouxu and unassigned Mark-Simulacrum Sep 3, 2025

jieyouxu approved these changes Sep 3, 2025

View reviewed changes

jieyouxu added the O-cygwin Target: *-pc-cygwin label Sep 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request Sep 3, 2025

Rollup merge of rust-lang#146140 - jeremyd2019:patch-1, r=jieyouxu

51d7cad

compiletest: cygwin follows windows in using PATH for dynamic libraries ``@Berrysoft``

tgross35 mentioned this pull request Sep 3, 2025

Rollup of 9 pull requests #146142

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 3, 2025

Rollup merge of rust-lang#146140 - jeremyd2019:patch-1, r=jieyouxu

c88847f

compiletest: cygwin follows windows in using PATH for dynamic libraries ```@Berrysoft```

jhpratt mentioned this pull request Sep 3, 2025

Rollup of 15 pull requests #146153

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 3, 2025

Rollup merge of rust-lang#146140 - jeremyd2019:patch-1, r=jieyouxu

6f20c43

compiletest: cygwin follows windows in using PATH for dynamic libraries ````@Berrysoft````

Zalathar mentioned this pull request Sep 3, 2025

Rollup of 16 pull requests #146158

Closed

bjorn3 reviewed Sep 3, 2025

View reviewed changes

src/tools/compiletest/src/util.rs Show resolved Hide resolved

Zalathar mentioned this pull request Sep 4, 2025

Rollup of 24 pull requests #146185

Merged

bors merged commit 9214b18 into rust-lang:master Sep 4, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Sep 4, 2025

rust-timer added a commit that referenced this pull request Sep 4, 2025

Unrolled build for #146140

a9744cc

Rollup merge of #146140 - jeremyd2019:patch-1, r=jieyouxu compiletest: cygwin follows windows in using PATH for dynamic libraries `@Berrysoft`

jeremyd2019 deleted the patch-1 branch September 4, 2025 18:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

compiletest: cygwin follows windows in using PATH for dynamic libraries #146140

compiletest: cygwin follows windows in using PATH for dynamic libraries #146140

jeremyd2019 commented Sep 2, 2025

Uh oh!

rustbot commented Sep 2, 2025

Uh oh!

rustbot commented Sep 2, 2025

Uh oh!

jeremyd2019 commented Sep 3, 2025

Uh oh!

rustbot commented Sep 3, 2025

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

Uh oh!

jieyouxu commented Sep 3, 2025

Uh oh!

bors commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

jeremyd2019 commented Sep 4, 2025 •

edited

Loading

Uh oh!

Uh oh!

compiletest: cygwin follows windows in using PATH for dynamic libraries #146140

compiletest: cygwin follows windows in using PATH for dynamic libraries #146140

Conversation

jeremyd2019 commented Sep 2, 2025

Uh oh!

rustbot commented Sep 2, 2025

Uh oh!

rustbot commented Sep 2, 2025

Uh oh!

jeremyd2019 commented Sep 3, 2025

Uh oh!

rustbot commented Sep 3, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Sep 3, 2025

Uh oh!

bors commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

jeremyd2019 commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jieyouxu left a comment •

edited by rustbot

Loading

jeremyd2019 commented Sep 4, 2025 •

edited

Loading