Skip to content

Improve support for fixed vector patterns #14624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Improve support for fixed vector patterns #14624

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2014

This is WIP, I want to get some numbers on the cost of using the slow-path exhaustiveness logic in let and function args.

@@ -1,32 +0,0 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this test removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton Should have made this clear. It wasn't so much removed as it was renamed to refutable-pattern-errors.rs now that the error messages aren't as detailed any more (they're not annotated with the specific pattern spans). Which is somewhat unfortunate but making them more detailed in the general case is something I'd like to address separately.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton Actually, looking at the history of that file, looks like this was introduced very recently: 0df221e In which case, I'll look into how we can preserve that level of detail.

cc @huonw

@ghost ghost closed this Jun 7, 2014
@ghost ghost deleted the fixed-vector-patterns branch June 7, 2014 18:27
@ghost
Copy link
Author

ghost commented Jun 7, 2014

I'm doing this in https://github.com/jakub-/rust/tree/pattern-matching-refactor now. I'll open a new PR once that's mergable.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
Fix panic in const eval and parameter destructing

fix rust-lang#14624
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant