Skip to content

Use Itertools::all_equal_value() where applicable #146254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2025
Merged

Use Itertools::all_equal_value() where applicable #146254

merged 1 commit into from
Sep 7, 2025

Conversation

yotamofek
Copy link
Contributor

Just a small cleanup.
We already have itertools as a dep in these crates, so might as well use another of its features.
Makes the code simpler IMHO :)

@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@cjgillot
Copy link
Contributor

cjgillot commented Sep 7, 2025

Thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit f279ae1 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2025
Merged
bors added a commit that referenced this pull request Sep 7, 2025
@bors
Auto merge of #146292 - matthiaskrgr:rollup-bkjs887, r=matthiaskrgr
fbd8f95 
Rollup of 2 pull requests

Successful merges:

 - #146254 (Use `Itertools::all_equal_value()` where applicable)
 - #146290 (Revert "Add LSX accelerated implementation for source file analysis")

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cb8b5fa into rust-lang:master Sep 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
rust-timer added a commit that referenced this pull request Sep 7, 2025
@rust-timer
Unrolled build for #146254
2e45bed 
Rollup merge of #146254 - yotamofek:pr/itertools-all-equal-value, r=cjgillot

Use `Itertools::all_equal_value()` where applicable

Just a small cleanup.
We already have `itertools` as a dep in these crates, so might as well use another of its features.
Makes the code simpler IMHO :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davidtwco davidtwco

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@yotamofek @rustbot @cjgillot @bors @davidtwco