Add a CI job that runs a subset of UI tests with the GCC backend #146414

GuillaumeGomez · 2025-09-10T14:42:45Z

Part of rust-lang/compiler-team#891.

r? @Kobzol

Kobzol · 2025-09-10T15:36:41Z

We can also specify the doc_url of the job (

rust/src/ci/github-actions/jobs.yml

Line 345 in 5d41f7c

doc_url: https://rustc-dev-guide.rust-lang.org/tests/rust-for-linux.html

) to this: https://rustc-dev-guide.rust-lang.org/tests/codegen-backend-tests/cg_gcc.html

GuillaumeGomez · 2025-09-10T20:38:16Z

Error in ui tests:

2025-09-10T20:29:55.1757480Z -	error: couldn't load codegen backend /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_gcc-1.91.0-nightly.so: libgccjit.so.0: cannot open shared object file: No such file or directory
2025-09-10T20:29:55.1758929Z +	error: couldn't load codegen backend $BUILD_DIR/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends/librustc_codegen_gcc-1.91.0-nightly.so: libgccjit.so.0: cannot open shared object file: No such file or directory

Seems like something went wrong with the build/install of libgccjit. Any idea @Kobzol? I thought libgccjit was built with bootstrap if download-ci-gcc was set to false but maybe I misunderstood something.

tgross35 · 2025-09-10T21:32:25Z

Is the .so actually in the load path? For some reason the GCC backend works differently than clif for me locally and I often find I need to manually append LD_LIBRARY_PATH, wonder if it could be something similar here.

GuillaumeGomez · 2025-09-11T14:52:11Z

Arf, it's the usual case of "it works locally for me". :-/

Gonna try to investigate if it's something wrong with paths.

GuillaumeGomez · 2025-09-11T15:32:40Z

Seems like we don't copy the .so files when we build gcc unlike when we download it.

…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? `@GuillaumeGomez`

…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? ``@GuillaumeGomez``

…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? ```@GuillaumeGomez```

Rollup merge of #146449 - Kobzol:gcc-fix-symlink, r=GuillaumeGomez Fix `libgccjit` symlink when we build GCC locally Unblocks #146414. r? ```@GuillaumeGomez```

Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang/rust#146414. r? ```@GuillaumeGomez```

…nding from inline asm

Initialize llvm submodule if not already the case to run citool While working on rust-lang/rust#146414, I ran the following command (to run CI docker locally): ``` cargo run --manifest-path src/ci/citool/Cargo.toml run-local --type pr x86_64-gnu-gcc ``` However, since I didn't have `src/llvm` submodule initialized, it failed. Apparently it's a common issue for people using this tool so this PR removes this small inconvenience. r? ``@Kobzol``

GuillaumeGomez · 2025-10-03T12:20:59Z

@Kobzol It's ready to review.

Kobzol

The GCC job spends a bunch of time documenting rustc and other things. Is the GCC backend actually used for anything when documenting (doctests?). If not, we could skip that.

Could you remove the temporary comment of the GCC download? I want to check that the job downloads GCC properly and I want to see how long it takes.

View changes since this review

Kobzol · 2025-10-03T12:27:02Z

src/bootstrap/src/core/build_steps/test.rs

        let target = run.target;

+        // GCC cannot run coverage tests.
+        if let Some(codegen_backend) = run.builder.config.cmd.test_codegen_backend() {


Let's at least print some warning when these tests are skipped.

Actually, I think that it will be better to just ignore these tests in the CI config. Let's use ./x test --stage 2 tests --skip tests/coverage --skip tests/coverage-run-rustdoc in the Dockerfile.

Kobzol · 2025-10-03T12:28:27Z

src/ci/github-actions/jobs.yml

    <<: *job-linux-4c
  - name: x86_64-gnu-miri
    <<: *job-linux-4c
+  - name: x86_64-gnu-gcc


Note: remove before merging.

Don't we want this to run on each PR or did I misunderstand when this one is run?

Kobzol · 2025-10-03T12:28:33Z

src/ci/run.sh


  # Download GCC from CI on test builders
-  RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set gcc.download-ci-gcc=true"
+  # FIXME: Temporarily commented out until the GCC build/download strategy is cleared out or


Note: remove before merging.

Kobzol · 2025-10-03T12:45:45Z

src/bootstrap/src/core/build_steps/test.rs

            return;
        }

+        // It we were running with GCC backend tests, no need to run these tests.


This is a bit unobvious, why should the GCC codegen tests be ignored?

They run tests/ui, which has already been run. Gonna update the comment.

That assumes a specific execution from our CI. Someone could run x test <cg_gcc> with the GCC backend, which should work.

In any case, we should modify the CI test command in the Dockerfile to not run this test at all. So I would also revert this change.

Yeah good point.

Kobzol · 2025-10-03T12:47:07Z

src/bootstrap/src/core/build_steps/test.rs

        let target = run.target;

+        // GCC cannot run coverage tests.
+        if let Some(codegen_backend) = run.builder.config.cmd.test_codegen_backend() {


Actually, I think that it will be better to just ignore these tests in the CI config. Let's use ./x test --stage 2 tests --skip tests/coverage --skip tests/coverage-run-rustdoc in the Dockerfile.

GuillaumeGomez · 2025-10-03T12:52:32Z

The GCC job spends a bunch of time documenting rustc and other things. Is the GCC backend actually used for anything when documenting (doctests?). If not, we could skip that.

Good idea.

Could you remove the temporary comment of the GCC download? I want to check that the job downloads GCC properly and I want to see how long it takes.

Sure.

Zalathar · 2025-10-06T02:14:24Z

tests/coverage-run-rustdoc/doctest.rs

@@ -1,4 +1,5 @@
 //@ aux-build:doctest_crate.rs
+//@ ignore-backends: gcc


Nit: Since we're now skipping the whole suite in the Dockerfile, this test doesn't need an explicit ignore.

Good catch, thanks!

rustbot assigned Kobzol Sep 10, 2025

GuillaumeGomez changed the title ~~Run rust tests with GCC backend~~ Run tests with GCC backend Sep 10, 2025

GuillaumeGomez mentioned this pull request Sep 10, 2025

Add missing documentation for running tests with GCC backend rust-lang/rustc-dev-guide#2587

Merged

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from e2d0466 to 2c2dac0 Compare September 10, 2025 16:32

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch 2 times, most recently from dfd72e4 to bbdbe70 Compare September 10, 2025 17:53

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch 2 times, most recently from 6bcf347 to 3a3bcf7 Compare September 10, 2025 18:24

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 3a3bcf7 to 0efa10e Compare September 10, 2025 19:32

Kobzol mentioned this pull request Sep 11, 2025

Fix libgccjit symlink when we build GCC locally #146449

Merged

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025

Rollup merge of rust-lang#146449 - Kobzol:gcc-fix-symlink, r=Guillaum…

bfc33ef

…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? `@GuillaumeGomez`

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025

Rollup merge of rust-lang#146449 - Kobzol:gcc-fix-symlink, r=Guillaum…

9ff3ffc

…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? ``@GuillaumeGomez``

Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 12, 2025

Rollup merge of rust-lang#146449 - Kobzol:gcc-fix-symlink, r=Guillaum…

accb4a3

…eGomez Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang#146414. r? ```@GuillaumeGomez```

rust-timer added a commit that referenced this pull request Sep 12, 2025

Unrolled build for #146449

e5ef98e

Rollup merge of #146449 - Kobzol:gcc-fix-symlink, r=GuillaumeGomez Fix `libgccjit` symlink when we build GCC locally Unblocks #146414. r? ```@GuillaumeGomez```

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 0efa10e to 7d861fe Compare September 12, 2025 16:01

This comment has been minimized.

Sign in to view

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 13, 2025

Rollup merge of #146449 - Kobzol:gcc-fix-symlink, r=GuillaumeGomez

cb548d7

Fix `libgccjit` symlink when we build GCC locally Unblocks rust-lang/rust#146414. r? ```@GuillaumeGomez```

GuillaumeGomez mentioned this pull request Sep 16, 2025

Do not run ui test if options specific to LLVM are used when another codegen backend is used #146618

Merged

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 0e66bc1 to fad2ab4 Compare October 2, 2025 16:02

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 2, 2025

This comment has been minimized.

Sign in to view

Ignore some mir-opt tests because GCC backend does not support unwi…

3df6f36

…nding from inline asm

This comment has been minimized.

Sign in to view

Ignore failing incremental tests for GCC backend

4bee877

This comment has been minimized.

Sign in to view

Ignore failing debuginfo tests with gcc backend

2ae5737

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 3403655 to 2ae5737 Compare October 2, 2025 22:48

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 9ee26a6 to 042451c Compare October 3, 2025 09:37

Kobzol reviewed Oct 3, 2025

View reviewed changes

Kobzol changed the title ~~Run tests with GCC backend~~ Add a CI job that runs a subset of UI tests with the GCC backend Oct 3, 2025

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 042451c to 63d5352 Compare October 3, 2025 13:07

This comment has been minimized.

Sign in to view

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 63d5352 to 5b36236 Compare October 3, 2025 13:31

Zalathar reviewed Oct 6, 2025

View reviewed changes

Skip GCC backend-specific test if current backend is already gcc

039fdd2

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from 5b36236 to fbf75ff Compare October 6, 2025 09:23

This comment has been minimized.

Sign in to view

GuillaumeGomez added 2 commits October 6, 2025 11:41

Ignore failing gcc backend testsuite directly in Dockerfile

66c735a

Re-enable libgccjit download in CI

bf2b742

GuillaumeGomez force-pushed the run-test-with-gcc-backend branch from fbf75ff to bf2b742 Compare October 6, 2025 09:42

		@@ -1,4 +1,5 @@
		//@ aux-build:doctest_crate.rs
		//@ ignore-backends: gcc

Add a CI job that runs a subset of UI tests with the GCC backend #146414

Are you sure you want to change the base?

Add a CI job that runs a subset of UI tests with the GCC backend #146414

Conversation

GuillaumeGomez commented Sep 10, 2025

Uh oh!

Kobzol commented Sep 10, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Sep 10, 2025

Uh oh!

tgross35 commented Sep 10, 2025

Uh oh!

GuillaumeGomez commented Sep 11, 2025

Uh oh!

GuillaumeGomez commented Sep 11, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

GuillaumeGomez commented Oct 3, 2025

Uh oh!

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Oct 3, 2025

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

Kobzol left a comment •

edited by rustbot

Loading