Skip to content

Conversation

@jdonszelmann
Copy link
Contributor

r? @lcnr

Just the comment update separately from https://github.com/rust-lang/rust/pull/146348/files since it doesn't really belong in that PR. Should be trivial

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2025
@jdonszelmann jdonszelmann force-pushed the update-fixme-compare_method_predicate_entailment branch from cc1dcd8 to 365189e Compare September 13, 2025 17:12
@jdonszelmann
Copy link
Contributor Author

@bors r=lcnr

@bors
Copy link
Collaborator

bors commented Sep 13, 2025

📌 Commit 365189e has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025
@bors
Copy link
Collaborator

bors commented Sep 13, 2025

⌛ Testing commit 365189e with merge 02c7b1a...

@bors
Copy link
Collaborator

bors commented Sep 13, 2025

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 02c7b1a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 13, 2025
@bors bors merged commit 02c7b1a into rust-lang:master Sep 13, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 13, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 637b50b (parent) -> 02c7b1a (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 02c7b1a7ac1d739663878030510508372e46f254 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1777.1s -> 1364.2s (-23.2%)
  2. dist-apple-various: 4071.3s -> 3195.9s (-21.5%)
  3. aarch64-gnu-llvm-19-1: 3924.2s -> 3238.1s (-17.5%)
  4. aarch64-gnu-debug: 4474.6s -> 3786.9s (-15.4%)
  5. aarch64-apple: 5884.8s -> 5049.7s (-14.2%)
  6. x86_64-gnu-llvm-19: 2765.8s -> 2426.6s (-12.3%)
  7. aarch64-msvc-1: 6461.7s -> 7186.0s (11.2%)
  8. aarch64-gnu-llvm-19-2: 2504.9s -> 2231.8s (-10.9%)
  9. dist-x86_64-windows-gnullvm: 4657.9s -> 5161.9s (10.8%)
  10. x86_64-gnu-llvm-20-1: 3620.1s -> 3267.9s (-9.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (02c7b1a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.269s -> 473.393s (-0.18%)
Artifact size: 390.15 MiB -> 390.19 MiB (0.01%)

makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
…thod_predicate_entailment, r=lcnr

update fixme in compare_method_predicate_entailment resulting from review of EII

r? `@lcnr`

Just the comment update separately from https://github.com/rust-lang/rust/pull/146348/files since it doesn't really belong in that PR. Should be trivial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants