Skip to content

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 15, 2025

These were stabilized very recently, maybe there's still a chance to not use the legacy const generic style here?

Though... is crater even going to be useful here? I assume the crater machines do not have AVX512 so depending on how the intrinsics are used, that code might be disabled anyway. @Amanieu

Context: rust-lang/stdarch#1916

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 15, 2025
@RalfJung
Copy link
Member Author

@bors try

rust-bors bot added a commit that referenced this pull request Sep 15, 2025
[crater experiment] avx512: remove rustc_legacy_const_generics
@rust-bors

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Sep 15, 2025

☀️ Try build successful (CI)
Build commit: f274f8f (f274f8f8a2a2f67248f608614f6bcc4b846fa998, parent: d1ed52b1f5b78bf66127b670af813b84d57aeedb)

@RalfJung
Copy link
Member Author

Turns out there wasn't actually a team decision to deprecate this so I guess there's little point in cratering.

@RalfJung RalfJung closed this Sep 15, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants