Skip to content

Make llvm_enzyme a regular cargo feature #146598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

Make llvm_enzyme a regular cargo feature #146598

merged 1 commit into from
Sep 18, 2025

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Sep 15, 2025

This makes it clearer that it is set by the build system rather than by the rustc that compiles the current rustc. It also avoids bootstrap needing to pass --check-cfg llvm_enzyme to rustc.

@bjorn3
Make llvm_enzyme a regular cargo feature
1991779 
This makes it clearer that it is set by the build system rather than by
the rustc that compiles the current rustc. It also avoids bootstrap
needing to pass --check-cfg llvm_enzyme to rustc.
@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2025

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_codegen_llvm/src/llvm/enzyme_ffi.rs

cc @ZuseZ4

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lcnr
Copy link
Contributor

lcnr commented Sep 16, 2025

r? compiler

@rustbot rustbot assigned davidtwco and unassigned lcnr Sep 16, 2025
@davidtwco
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 17, 2025

📌 Commit 1991779 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
@jdonszelmann jdonszelmann mentioned this pull request Sep 17, 2025
Merged
bors added a commit that referenced this pull request Sep 17, 2025
@bors
Auto merge of #146685 - jdonszelmann:rollup-kwuih4z, r=jdonszelmann
9311767 
Rollup of 7 pull requests

Successful merges:

 - #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
 - #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
 - #146536 (clean up several trait related UI tests)
 - #146598 (Make llvm_enzyme a regular cargo feature)
 - #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
 - #146654 (Do not use `git -C dir`)
 - #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9303a92 into rust-lang:master Sep 18, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
@rust-timer
Unrolled build for #146598
0388871 
Rollup merge of #146598 - bjorn3:feature_llvm_enzyme, r=davidtwco

Make llvm_enzyme a regular cargo feature

This makes it clearer that it is set by the build system rather than by the rustc that compiles the current rustc. It also avoids bootstrap needing to pass `--check-cfg llvm_enzyme` to rustc.
@bjorn3 bjorn3 deleted the feature_llvm_enzyme branch September 18, 2025 08:55
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@bors
Auto merge of rust-lang#146685 - jdonszelmann:rollup-kwuih4z, r=jdons…
66aeb91 
…zelmann

Rollup of 7 pull requests

Successful merges:

 - rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
 - rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
 - rust-lang#146536 (clean up several trait related UI tests)
 - rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
 - rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
 - rust-lang#146654 (Do not use `git -C dir`)
 - rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-autodiff `#![feature(autodiff)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@bjorn3 @rustbot @lcnr @davidtwco @bors