Skip to content

std: Fix WASI implementation of remove_dir_all #146691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
+8 −1
Merged

std: Fix WASI implementation of remove_dir_all #146691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion library/std/src/sys/fs/wasi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,7 +848,14 @@ fn remove_dir_all_recursive(parent: &WasiFd, path: &Path) -> io::Result<()> {

// Iterate over all the entries in this directory, and travel recursively if
// necessary
for entry in ReadDir::new(fd, dummy_root) {
//
// Note that all directory entries for this directory are read first before
// any removal is done. This works around the fact that the WASIp1 API for
// reading directories is not well-designed for handling mutations between
// invocations of reading a directory. By reading all the entries at once
// this ensures that, at least without concurrent modifications, it should
// be possible to delete everything.
for entry in ReadDir::new(fd, dummy_root).collect::<Vec<_>>() {
let entry = entry?;
let path = crate::str::from_utf8(&entry.name).map_err(|_| {
io::const_error!(io::ErrorKind::Uncategorized, "invalid utf-8 file name found")
Expand Down
Loading