[rustdoc] Finish getting rid of usages write_str
#146942
Conversation
rustbot
added
S-waiting-on-review
|
rustbot has assigned @GuillaumeGomez. Use |
|
Looks good to me, thanks! Just by curiosity, let's see if there is any impact on performance. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…_str, r=<try> [rustdoc] Finish getting rid of usages `write_str`
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (e228982): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 472.868s -> 473.031s (0.03%) |
rustbot
removed
the
S-waiting-on-perf
|
Thanks! |
|
Ah sure, didn't see it. Let's wait for the other one first then. |
yotamofek
force-pushed
the
pr/rustdoc/finish_deprecating_write_str
branch
from
8f2e717 to
a40032d
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@GuillaumeGomez quick approval here, please? edit: after CI is green, ofc :) |
|
r=me once CI pass then. :) @bors delegate+ |
|
✌️ @yotamofek, you can now approve this pull request! If @GuillaumeGomez told you to " |
bors
added
S-waiting-on-bors
|
If the perf changes are bogus, and the other PR has already merged, then this seems fine for rollup. @bors rollup=maybe |
…ating_write_str, r=GuillaumeGomez [rustdoc] Finish getting rid of usages `write_str` This PR, along with rust-lang#146933 , get rid of all the last usages of the `write_str` fn that was introduced back in rust-lang#136784 . This *shouldn't* be rolled up along with rust-lang#146933 , since the later of the two to be merged will need to delete the no-longer-used `write_str` fn. Commits can be reviewed separately.
Rollup of 16 pull requests Successful merges: - #142139 (Include additional hashes in src/stage0) - #146745 (Clarified error note for usize range matching) - #146763 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 5)) - #146788 (chore: removes deprecated discord.) - #146942 ([rustdoc] Finish getting rid of usages `write_str`) - #147002 (rustdoc-search: stringdex update with more packing) - #147061 (fix rebasing cycle heads when not reaching a fixpoint) - #147066 (Fix tracking issue number for feature(macro_attr)) - #147081 (doc: fix a typo in platform-support.md) - #147082 (formatting_options: fix alternate docs 0b/0o mixup) - #147086 (compiletest: Use `PanicHookInfo::payload_as_str` now that it's stable in beta) - #147092 (Do not compute optimized MIR if code does not type-check.) - #147093 (redox: switch to colon as path separator) - #147095 (Library: Remove remaining private `#[repr]` workarounds) - #147098 (Add auto extra-checks in pre-push hook) - #147110 (Fix typo) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 14 pull requests Successful merges: - #142139 (Include additional hashes in src/stage0) - #146745 (Clarified error note for usize range matching) - #146763 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 5)) - #146788 (chore: removes deprecated discord.) - #146942 ([rustdoc] Finish getting rid of usages `write_str`) - #147061 (fix rebasing cycle heads when not reaching a fixpoint) - #147066 (Fix tracking issue number for feature(macro_attr)) - #147081 (doc: fix a typo in platform-support.md) - #147082 (formatting_options: fix alternate docs 0b/0o mixup) - #147086 (compiletest: Use `PanicHookInfo::payload_as_str` now that it's stable in beta) - #147093 (redox: switch to colon as path separator) - #147095 (Library: Remove remaining private `#[repr]` workarounds) - #147098 (Add auto extra-checks in pre-push hook) - #147110 (Fix typo) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #146942 - yotamofek:pr/rustdoc/finish_deprecating_write_str, r=GuillaumeGomez [rustdoc] Finish getting rid of usages `write_str` This PR, along with #146933 , get rid of all the last usages of the `write_str` fn that was introduced back in #136784 . This *shouldn't* be rolled up along with #146933 , since the later of the two to be merged will need to delete the no-longer-used `write_str` fn. Commits can be reviewed separately.
This PR, along with #146933 , get rid of all the last usages of the
write_strfn that was introduced back in #136784 .This shouldn't be rolled up along with #146933 , since the later of the two to be merged will need to delete the no-longer-used
write_strfn.Commits can be reviewed separately.