Fix doctest compilation time display #147032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-doctest-compilation-time-display
branch
from
5a77d88 to
2255e82
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-doctest-compilation-time-display
branch
from
2255e82 to
9844d2e
Compare
|
Added the missing normalizations. |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-doctest-compilation-time-display
branch
from
9844d2e to
b8e4db9
Compare
|
I keep discovering more tests that were actually buggy. ^^' Anyway, fixed the |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-doctest-compilation-time-display
branch
from
b8e4db9 to
1e458ea
Compare
|
CI passed. \o/ |
| use run_make_support::rfs::write; | ||
| use run_make_support::{cwd, rustdoc}; | ||
|
|
||
| fn check_present_of_compilation_time_report( |
There was a problem hiding this comment.
Suggested change
| fn check_present_of_compilation_time_report( | |
| fn assert_presence_of_compilation_time_report( |
check -> assert since this function asserts directly instead of returning a bool.
present -> presence for grammaticality.
| true, | ||
| true, | ||
| ); | ||
| // Checking with only fainling merged doctests. |
There was a problem hiding this comment.
Suggested change
| // Checking with only fainling merged doctests. | |
| // Checking with only failing merged doctests. |
GuillaumeGomez
force-pushed
the
fix-doctest-compilation-time-display
branch
from
1e458ea to
b7e444d
Compare
|
@bors r=lolbinarycat rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 27, 2025
…tion-time-display, r=lolbinarycat Fix doctest compilation time display Fixes rust-lang#146960. Small corner case that happened in case everything went fine and there was only merged doctests. r? lolbinarycat
bors
added a commit
that referenced
this pull request
Sep 27, 2025
Rollup of 9 pull requests Successful merges: - #140482 (std::net: update tcp deferaccept delay type to Duration.) - #146037 (Introduce CoerceShared lang item and trait, and basic Reborrow tests) - #146732 (tests: relax expectations after llvm change 902ddda120a5) - #147018 (re-order normalizations in run-make linker-warning test) - #147032 (Fix doctest compilation time display) - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`) - #147050 (PassWrapper: update for new PGOOptions args in LLVM 22) - #147075 (Make `def_path_hash_to_def_id` not panic when passed an invalid hash) - #147076 (update issue number for more_float_constants) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 27, 2025
Rollup of 8 pull requests Successful merges: - #146037 (Introduce CoerceShared lang item and trait, and basic Reborrow tests) - #146732 (tests: relax expectations after llvm change 902ddda120a5) - #147018 (re-order normalizations in run-make linker-warning test) - #147032 (Fix doctest compilation time display) - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`) - #147050 (PassWrapper: update for new PGOOptions args in LLVM 22) - #147075 (Make `def_path_hash_to_def_id` not panic when passed an invalid hash) - #147076 (update issue number for more_float_constants) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146960.
Small corner case that happened in case everything went fine and there was only merged doctests.
r? lolbinarycat