Skip to content

tests: Remove ignore-android directive for fixed issue #147100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

tests: Remove ignore-android directive for fixed issue #147100

merged 1 commit into from
Sep 29, 2025
+3 −5

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Sep 27, 2025 •
edited by jieyouxu
Loading

#120567 is marked as fixed, so let's see if we can remove the ignore directives tied to that issue.

try-job: arm-android

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 27, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jieyouxu jieyouxu self-assigned this Sep 28, 2025
@jieyouxu
Copy link
Member

@bors2 delegate=try

@rust-bors
Copy link

rust-bors bot commented Sep 28, 2025

✌️ @Enselic, you can now perform try builds on this pull request!

You can now post @bors2 try to start a try build.

@jieyouxu
Copy link
Member

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 29, 2025
@rust-bors
Auto merge of #147100 - Enselic:ignore-less, r=<try>
f72a28c 
tests: Remove ignore-android directive for fixed issue

try-job: arm-android
@rust-bors
Copy link

rust-bors bot commented Sep 29, 2025

☀️ Try build successful (CI)
Build commit: f72a28c (f72a28cae44de4876dbe83c73b8414e92fa783e0, parent: f957826bff7a68b267ce75b1ea56352aed0cca0a)

@Enselic
Copy link
Member Author

Enselic commented Sep 29, 2025

Thanks for triggering, the changed tests pass on arm-android:

  running 2 tests
  test [ui] tests/ui/test-attrs/test-panic-abort-nocapture.rs ... ok
  test [ui] tests/ui/test-attrs/test-panic-abort.rs ... ok
  
  test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 19853 filtered out; finished in 945.60ms

maybe you can also set r+?

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2025

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

jieyouxu
jieyouxu approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 29, 2025

📌 Commit fa53de6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2025
@Zalathar Zalathar mentioned this pull request Sep 29, 2025
Merged
bors added a commit that referenced this pull request Sep 29, 2025
@bors
Auto merge of #147145 - Zalathar:rollup-s7kcs3w, r=Zalathar
128b36a 
Rollup of 3 pull requests

Successful merges:

 - #147100 (tests: Remove ignore-android directive for fixed issue)
 - #147116 (compiler: remove AbiAlign inside TargetDataLayout)
 - #147134 (remove explicit deref of AbiAlign for most methods)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d9e3e19 into rust-lang:master Sep 29, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 29, 2025
rust-timer added a commit that referenced this pull request Sep 29, 2025
@rust-timer
Unrolled build for #147100
7caa3c9 
Rollup merge of #147100 - Enselic:ignore-less, r=jieyouxu

tests: Remove ignore-android directive for fixed issue

#120567 is marked as fixed, so let's see if we can remove the ignore directives tied to that issue.

<!-- Note to self: wait for rust-lang/team#2002 -->

try-job: arm-android
@Enselic Enselic mentioned this pull request Sep 29, 2025
Closed
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 30, 2025
@bors
Auto merge of #147145 - Zalathar:rollup-s7kcs3w, r=Zalathar
3507b03 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue)
 - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout)
 - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods)

r? `@ghost`
`@rustbot` modify labels: rollup
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Oct 1, 2025
@bors
Auto merge of #147145 - Zalathar:rollup-s7kcs3w, r=Zalathar
46ce2bf 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue)
 - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout)
 - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods)

r? `@ghost`
`@rustbot` modify labels: rollup
antoyo pushed a commit to rust-lang/rustc_codegen_gcc that referenced this pull request Oct 1, 2025
@bors
Auto merge of #147145 - Zalathar:rollup-s7kcs3w, r=Zalathar
68c97a8 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue)
 - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout)
 - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Oct 2, 2025
@bors
Auto merge of #147145 - Zalathar:rollup-s7kcs3w, r=Zalathar
e7ad0d7 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue)
 - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout)
 - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Enselic @rust-log-analyzer @jieyouxu @rustbot @bors