compiler: remove AbiAlign inside TargetDataLayout #147116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This maintains AbiAlign usage in public API and most of the compiler, but direct access of these fields is now in terms of Align only.
|
Some changes occurred in cfg and check-cfg configuration cc @Urgau |
rustbot
added
the
A-LLVM
rustbot
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
...I have no idea how this affected rustdoc. |
|
It's protocol errors so likely a test suite error. |
rustbot
added
S-waiting-on-review
|
LGTM @bors r+ |
bors
added
S-waiting-on-bors
Zalathar
reviewed
Sep 29, 2025
Comment on lines
+662
to
+664
| AbiAlign::new(if c == self.default_address_space { | ||
| self.default_address_space_pointer_spec.pointer_align | ||
| } else if let Some(e) = self.address_space_info.iter().find(|(a, _)| a == &c) { |
There was a problem hiding this comment.
Remark: In general I'm not fond of putting a complex conditional in the constructor call; I would have written this as let align = ...; followed by a separate AbiAlign::new(align).
(But in the context of a big ongoing cleanup it's also not worth haggling over, so whatever.)
rust-timer
added a commit
that referenced
this pull request
Sep 29, 2025
Rollup merge of #147116 - workingjubilee:remove-tdl-abialign, r=Zalathar compiler: remove AbiAlign inside TargetDataLayout AbiAlign is a thin wrapper around Align, extant mostly because we used to track a separate quasi-notion of alignment that was never a real notion of alignment and removing all of it at once was too churny. This PR maintains AbiAlign usage in public API and most of the compiler, but direct access of these fields for TargetDataLayout is now in terms of Align only.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 30, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue) - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout) - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods) r? `@ghost` `@rustbot` modify labels: rollup
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Oct 1, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue) - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout) - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods) r? `@ghost` `@rustbot` modify labels: rollup
antoyo
pushed a commit
to rust-lang/rustc_codegen_gcc
that referenced
this pull request
Oct 1, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue) - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout) - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Oct 2, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#147100 (tests: Remove ignore-android directive for fixed issue) - rust-lang/rust#147116 (compiler: remove AbiAlign inside TargetDataLayout) - rust-lang/rust#147134 (remove explicit deref of AbiAlign for most methods) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbiAlign is a thin wrapper around Align, extant mostly because we used to track a separate quasi-notion of alignment that was never a real notion of alignment and removing all of it at once was too churny. This PR maintains AbiAlign usage in public API and most of the compiler, but direct access of these fields for TargetDataLayout is now in terms of Align only.
This PR is about the size limit I hit before it started to seem exhausting to continue working on or review, as changes elsewhere double the amount of "rest-of-compiler" code that gets touched.