Emscripten: Turn wasm-eh on by default #147224
Merged
+15
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
9 tasks
This comment has been minimized.
This comment has been minimized.
Contributor
|
I think this is blocked on a team decision? |
lcnr
added
S-waiting-on-team
rustbot
added
the
S-waiting-on-author
Contributor
Author
|
Indeed, waiting-on-MCP is the correct description. I turned it to a draft too, but I think it can merge as is once the MCP is approved. |
Contributor
Author
|
Well I guess test_unstable_options_tracking_hash will need to be updated too. |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
hoodmane
force-pushed
the
wasm-eh-default-on
branch
from
d94db1c to
ce366ac
Compare
This comment has been minimized.
This comment has been minimized.
hoodmane
force-pushed
the
wasm-eh-default-on
branch
2 times, most recently
from
434c3ca to
e8f5d21
Compare
Collaborator
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
hoodmane
force-pushed
the
wasm-eh-default-on
branch
from
e8f5d21 to
c238a3f
Compare
This comment has been minimized.
This comment has been minimized.
5 tasks
Contributor
|
r? @bjorn3 as the one who approved the MCP |
Contributor
Author
|
Okay Emscripten 4.0.21 was released yesterday so I think this is ready to move forward. |
Member
|
CI fails. |
Contributor
Author
|
The test //@ compile-flags: --check-cfg=cfg(emscripten_wasm_eh)
#[cfg(not(emscripten_wasm_eh))]
//~^ ERROR `cfg(emscripten_wasm_eh)` is experimental
fn main() {}I guess I need to negate the |
hoodmane
force-pushed
the
wasm-eh-default-on
branch
from
c238a3f to
9532301
Compare
This comment has been minimized.
This comment has been minimized.
hoodmane
force-pushed
the
wasm-eh-default-on
branch
from
9532301 to
dd65f8b
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Dec 3, 2025
hoodmane
force-pushed
the
wasm-eh-default-on
branch
from
dd65f8b to
59d0e3f
Compare
This comment has been minimized.
This comment has been minimized.
As specified by MCP: rust-lang/compiler-team#920 Resolves rust-lang#148309
hoodmane
force-pushed
the
wasm-eh-default-on
branch
from
59d0e3f to
f07a84f
Compare
Contributor
Author
|
Okay CI looks green now |
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 9 pull requests Successful merges: - #147224 (Emscripten: Turn wasm-eh on by default) - #149405 (Recover on misspelled item keyword) - #149443 (Tidying up UI tests [6/N]) - #149524 (Move attribute safety checking to attribute parsing) - #149593 (powf, powi: point out SNaN non-determinism) - #149605 (Use branch name instead of HEAD when unshallowing) - #149612 (Apply the `bors` environment also to the `outcome` job) - #149623 (Don't require a normal tool build of clippy/rustfmt when running their test steps) - #149627 (Point to the item that is incorrectly annotated with `#[diagnostic::on_const]`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 5, 2025
Rollup merge of #147224 - hoodmane:wasm-eh-default-on, r=bjorn3 Emscripten: Turn wasm-eh on by default As specified by [MCP](rust-lang/compiler-team#920) Resolves #148309 Resolves #112195
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 5, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#147224 (Emscripten: Turn wasm-eh on by default) - rust-lang/rust#149405 (Recover on misspelled item keyword) - rust-lang/rust#149443 (Tidying up UI tests [6/N]) - rust-lang/rust#149524 (Move attribute safety checking to attribute parsing) - rust-lang/rust#149593 (powf, powi: point out SNaN non-determinism) - rust-lang/rust#149605 (Use branch name instead of HEAD when unshallowing) - rust-lang/rust#149612 (Apply the `bors` environment also to the `outcome` job) - rust-lang/rust#149623 (Don't require a normal tool build of clippy/rustfmt when running their test steps) - rust-lang/rust#149627 (Point to the item that is incorrectly annotated with `#[diagnostic::on_const]`) r? `@ghost` `@rustbot` modify labels: rollup
bjorn3
added
the
relnotes
Contributor
Author
|
Thanks @bjorn3! |
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Dec 10, 2025
Since this commit `-Z emscripten-wasm-eh` is the default for the Rust compiler: rust-lang/rust#147224 This switches to a recent Rust nightly which includes this change. This means we don't need a custom sysroot anymore.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified by MCP
Resolves #148309
Resolves #112195