-
Notifications
You must be signed in to change notification settings - Fork 13.9k
intrinsic_raw query optimization attempt #147232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
df2f166 to
8c34776
Compare
This comment has been minimized.
This comment has been minimized.
8c34776 to
5b1d160
Compare
|
@petrochenkov, this is continuation of #146880. |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
intrinsic_raw query optimization attempt using inlined functions
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (c329581): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -5.7%, secondary 1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.5%, secondary -2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.999s -> 470.199s (-0.17%) |
|
intrinsic_raw query works like inlined function for non-incremental build and non-local DefId.
Optimization may be profitable for queries with low normalized average execution time (to replace cache lookup into inlined call) and be significant with good cache_hits.
Draft PR to measure performance changes.