-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[rustdoc] Cleanup "highlight::end_expansion" #147237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rustdoc] Cleanup "highlight::end_expansion" #147237
Conversation
This basically just removes two |
I'm curious to see the impact too. @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…xpansion, r=<try> [rustdoc] Optimize "highlight::end_expansion"
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (ce6801f): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.999s -> 472.425s (0.30%) |
Regression is on "opt" profile test, so most likely just noise. Otherwise perf is neutral :( |
Go ahead then, we can run another perf check once you pushed the change. |
fd23589
to
78c2e58
Compare
Done. |
Round 2! @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…xpansion, r=<try> [rustdoc] Optimize "highlight::end_expansion"
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (67e3f35): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.3%, secondary 2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.352s -> 470.242s (-0.02%) |
@GuillaumeGomez perf is neutral, WDYT about merging this in? :) |
Code is simpler so definitely! @bors r+ rollup |
Rollup merge of #147237 - yotamofek:pr/rustdoc/highlight/optimize-end_expansion, r=GuillaumeGomez [rustdoc] Cleanup "highlight::end_expansion" ~Looks like a ~5% improvement on the highlight benchmark. Obviously, highlighting is only a small part of rustdoc's runtime, so improvement won't be as large on rustc-perf (if there's even an improvement), but holding fingers for a nice gain.~ Perf seems neutral, but IMHO this is a nice small cleanup regardless. r? `@GuillaumeGomez` (& perf run please!)
~Looks like a
5% improvement on the highlight benchmark.Obviously, highlighting is only a small part of rustdoc's runtime, so improvement won't be as large on rustc-perf (if there's even an improvement), but holding fingers for a nice gain.
Perf seems neutral, but IMHO this is a nice small cleanup regardless.
r? @GuillaumeGomez (& perf run please!)