Skip to content

Conversation

Kivooeo
Copy link
Member

@Kivooeo Kivooeo commented Oct 4, 2025

As was explained here #147191 (comment), this reverting this change because flt is incorrect format

Also maybe there is existed PR for that? I didn't found one

Follow up #147191

cc @GuillaumeGomez

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@Noratrieb
Copy link
Member

now you need to fix the mess that has happened in the meantime :D

@Kivooeo
Copy link
Member Author

Kivooeo commented Oct 4, 2025

Haha, I just realized that, ok, give me some time I will fix everything

@Kivooeo
Copy link
Member Author

Kivooeo commented Oct 4, 2025

Unironically, but --bless fixed everything

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Oct 4, 2025
@Kivooeo
Copy link
Member Author

Kivooeo commented Oct 4, 2025

Ok maybe not everything

@rust-log-analyzer

This comment has been minimized.

@Kivooeo
Copy link
Member Author

Kivooeo commented Oct 4, 2025

Now it should be fine

@Kobzol
Copy link
Member

Kobzol commented Oct 5, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 5, 2025

📌 Commit 67bc030 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2025
@bors
Copy link
Collaborator

bors commented Oct 5, 2025

⌛ Testing commit 67bc030 with merge 981353c...

@bors
Copy link
Collaborator

bors commented Oct 5, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 981353c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 5, 2025
@bors bors merged commit 981353c into rust-lang:master Oct 5, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 5, 2025
Copy link
Contributor

github-actions bot commented Oct 5, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bcbbdcb (parent) -> 981353c (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 981353ca16018bb35e232684b5f91f0943bf45bf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 6159.0s -> 7986.1s (29.7%)
  2. i686-gnu-2: 5504.3s -> 6136.4s (11.5%)
  3. x86_64-gnu-llvm-20-1: 3186.1s -> 3525.2s (10.6%)
  4. aarch64-apple: 8757.8s -> 7874.1s (-10.1%)
  5. aarch64-gnu-llvm-20-1: 3467.0s -> 3815.4s (10.0%)
  6. tidy: 179.2s -> 193.5s (8.0%)
  7. x86_64-msvc-ext2: 5786.0s -> 5364.9s (-7.3%)
  8. x86_64-gnu-aux: 6209.6s -> 6625.2s (6.7%)
  9. x86_64-gnu-tools: 3220.4s -> 3398.6s (5.5%)
  10. x86_64-gnu-nopt: 7223.1s -> 6841.6s (-5.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (981353c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.8%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
-0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.8% [-0.8%, -0.8%] 1

Cycles

Results (primary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.313s -> 471.402s (-0.19%)
Artifact size: 388.36 MiB -> 388.23 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants