Skip to content

don't make empty ident when printing ' ident from extern "'" #147377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2025
Merged

don't make empty ident when printing ' ident from extern "'" #147377

merged 2 commits into from
Oct 6, 2025

Conversation

karolzwolak
Copy link
Member

@karolzwolak karolzwolak commented Oct 5, 2025 •
edited by rustbot
Loading

Fixes #147365.
r? @nnethercote

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2025
nnethercote
nnethercote reviewed Oct 6, 2025
View reviewed changes
compiler/rustc_span/src/symbol.rs
if self.name.as_str() == "'" {
return false;
}
let ident_without_apostrophe = self.without_first_quote();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up for the name/ident renaming here.

@nnethercote
Copy link
Contributor

Thanks for fixing the bug!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 6, 2025

📌 Commit 5234d36 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2025
@bors
Copy link
Collaborator

bors commented Oct 6, 2025

⌛ Testing commit 5234d36 with merge 1a3cdd3...

@bors
Copy link
Collaborator

bors commented Oct 6, 2025

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 1a3cdd3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 6, 2025
@bors bors merged commit 1a3cdd3 into rust-lang:master Oct 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 828c2a9 (parent) -> 1a3cdd3 (this PR)

Test differences

Show 6 test diffs

Stage 1

  • [ui] tests/ui/extern/extern-single-quote-issue-147365.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/extern/extern-single-quote-issue-147365.rs: [missing] -> pass (J0)
  • [ui] tests/ui/extern/extern-single-quote-issue-147365.rs: [missing] -> ignore (ignored if rustc wasn't built with debug assertions) (J2)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1a3cdd34629306fa67624eaa60d73687e7fcf855 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 3007.5s -> 2597.3s (-13.6%)
  2. dist-x86_64-apple: 7461.6s -> 6484.4s (-13.1%)
  3. i686-gnu-2: 5382.6s -> 6069.5s (12.8%)
  4. x86_64-gnu-llvm-20: 2610.2s -> 2893.4s (10.8%)
  5. aarch64-msvc-2: 4569.4s -> 5042.2s (10.3%)
  6. dist-apple-various: 4057.9s -> 3646.2s (-10.1%)
  7. dist-x86_64-msvc: 6675.9s -> 7347.0s (10.1%)
  8. x86_64-mingw-2: 7876.9s -> 7149.4s (-9.2%)
  9. pr-check-2: 2502.3s -> 2728.0s (9.0%)
  10. dist-android: 1655.6s -> 1525.0s (-7.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1a3cdd3): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.9% [0.8%, 1.0%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 7.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 7.2% [7.2%, 7.2%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 7.2% [7.2%, 7.2%] 1

Cycles

Results (secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.0% [5.0%, 5.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.991s -> 471.633s (0.35%)
Artifact size: 388.38 MiB -> 388.34 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Oct 6, 2025
@panstromek
Copy link
Contributor

perf triage:

Perf results are noise. Looks like wg-grammar became bimodal recently.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 6, 2025
@karolzwolak karolzwolak mentioned this pull request Oct 6, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#147413 - karolzwolak:extern-multiple-quotes…
e06d80f 
…, r=fmease

don't panic on extern with just multiple quotes in the name

Continues rust-lang#147377.
That PR fixed ICE when the extern name was a single quote `"'"`, but multiple quotes like `"''"` cause the same problem.
I had a random revelation that the trimming can remove more than one quote.
r? `@nnethercote`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 7, 2025
@matthiaskrgr
Rollup merge of rust-lang#147413 - karolzwolak:extern-multiple-quotes…
21bf6db 
…, r=fmease

don't panic on extern with just multiple quotes in the name

Continues rust-lang#147377.
That PR fixed ICE when the extern name was a single quote `"'"`, but multiple quotes like `"''"` cause the same problem.
I had a random revelation that the trimming can remove more than one quote.
r? ``@nnethercote``
rust-timer added a commit that referenced this pull request Oct 7, 2025
@rust-timer
Unrolled build for #147413
7c90685 
Rollup merge of #147413 - karolzwolak:extern-multiple-quotes, r=fmease

don't panic on extern with just multiple quotes in the name

Continues #147377.
That PR fixed ICE when the extern name was a single quote `"'"`, but multiple quotes like `"''"` cause the same problem.
I had a random revelation that the trimming can remove more than one quote.
r? ``@nnethercote``
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 8, 2025
@matthiaskrgr
Rollup merge of #147413 - karolzwolak:extern-multiple-quotes, r=fmease
cb2a31a 
don't panic on extern with just multiple quotes in the name

Continues rust-lang/rust#147377.
That PR fixed ICE when the extern name was a single quote `"'"`, but multiple quotes like `"''"` cause the same problem.
I had a random revelation that the trimming can remove more than one quote.
r? ``@nnethercote``
@karolzwolak karolzwolak deleted the dont-create-empty-ident-issue-147365 branch October 10, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nnethercote nnethercote nnethercote left review comments

Assignees

@nnethercote nnethercote

Labels

merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

ICE: "'" isn't ""

6 participants

@karolzwolak @nnethercote @bors @rust-timer @panstromek @rustbot