Skip to content

Suppress the error for private fields with non_exhaustive attribute #147585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 9, 2025
Merged

Suppress the error for private fields with non_exhaustive attribute #147585

bors merged 1 commit into from
Dec 9, 2025
+58 −1

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 11, 2025 •
edited by rustbot
Loading

Fixes #147513

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@chenyukang chenyukang mentioned this pull request Oct 11, 2025
Closed
@chenyukang chenyukang force-pushed the yukang-fix-147513-suppress-private-fields branch from cd43d42 to 3829ece Compare October 11, 2025 11:05
Darksonn
Darksonn reviewed Oct 11, 2025
View reviewed changes
@chenyukang chenyukang force-pushed the yukang-fix-147513-suppress-private-fields branch from 3829ece to 6a709e7 Compare October 11, 2025 11:15
@Kivooeo
Copy link
Member

Kivooeo commented Dec 8, 2025 •
edited
Loading

looks good to me r=me

@rustbot rustbot assigned Kivooeo and unassigned SparrowLii Dec 8, 2025
@chenyukang
Copy link
Member Author

chenyukang commented Dec 9, 2025

@bors r=Kivooeo

@bors
Copy link
Collaborator

bors commented Dec 9, 2025

📌 Commit 6a709e7 has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 9, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 9, 2025
Merged
bors added a commit that referenced this pull request Dec 9, 2025
@bors
Auto merge of #149798 - matthiaskrgr:rollup-wjgs9x6, r=matthiaskrgr
d5525a7 
Rollup of 11 pull requests

Successful merges:

 - #147585 (Suppress the error for private fields with non_exhaustive attribute)
 - #149215 (Emit `check-cfg` lints during attribute parsing rather than evaluation)
 - #149652 (Add release notes for 1.92.0)
 - #149720 (rustdoc book: mention inner doc attribute)
 - #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE)
 - #149754 (Retire `opt_str2` from compiletest cli parsing)
 - #149755 (bootstrap: Use a `CompiletestMode` enum instead of bare strings)
 - #149763 (Add inline attribute to generated delegation function if needed)
 - #149772 (test: Add a test for 146133)
 - #149779 (Fix typo "an" → "and")
 - #149782 (Remove `[no-mentions]` handler in the triagebot config)

Failed merges:

 - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type)

r? `@ghost`
`@rustbot` modify labels: rollup
@Kivooeo
Copy link
Member

Kivooeo commented Dec 9, 2025 •
edited
Loading

by "r? me" I meant only assigning myself and not "r=me" :D

But I take a look now and it seems fine, so I edited message

@rustbot

This comment was marked as resolved.

Sign in to view
1 similar comment
@rustbot

This comment was marked as duplicate.

Sign in to view
@bors bors merged commit 3c19acc into rust-lang:main Dec 9, 2025
10 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 9, 2025
rust-timer added a commit that referenced this pull request Dec 9, 2025
@rust-timer
Unrolled build for #147585
6973225 
Rollup merge of #147585 - chenyukang:yukang-fix-147513-suppress-private-fields, r=Kivooeo

Suppress the error for private fields with non_exhaustive attribute

Fixes #147513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Darksonn Darksonn Darksonn left review comments

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

6 participants

@chenyukang @rustbot @Kivooeo @bors @Darksonn @SparrowLii