Skip to content

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Oct 14, 2025

Two index format tweaks that reduce the size of the standard library, compiler, and wordnet dictionary when I test it.

CC #146048

FF Profiler output: https://share.firefox.dev/4onH5xP

Preview: https://notriddle.com/rustdoc-html-demo-12/stringdex-002/std/index.html

Two index format tweaks that reduce the size of the standard
library, compiler, and wordnet dictionary when I test it.
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 14, 2025
@notriddle
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 14, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 14, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 14, 2025

☀️ Try build successful (CI)
Build commit: 7174e3d (7174e3dd4a5b953adb06a575b83ac36bd1dbd7e3, parent: 4b94758d2ba7d0ef71ccf5fde29ce4bc5d6fe2a4)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7174e3d): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
-0.8% [-2.5%, -0.2%] 5
Improvements ✅
(secondary)
-3.0% [-5.7%, -0.3%] 2
All ❌✅ (primary) -0.8% [-2.5%, -0.2%] 5

Max RSS (memory usage)

Results (primary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

Results (secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.6% [3.6%, 3.6%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.312s -> 475.493s (0.04%)
Artifact size: 388.16 MiB -> 388.16 MiB (0.00%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 14, 2025
@notriddle
Copy link
Contributor Author

The "regression" is not in a doc build, so can't be real.

@notriddle notriddle marked this pull request as ready for review October 15, 2025 20:26
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@GuillaumeGomez
Copy link
Member

Nice perf improvement! :)

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Oct 16, 2025

📌 Commit fdeb363 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2025
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Oct 17, 2025
…meGomez

rustdoc-search: stringdex 0.0.2

Two index format tweaks that reduce the size of the standard library, compiler, and wordnet dictionary when I test it.

CC rust-lang#146048

FF Profiler output: https://share.firefox.dev/4onH5xP

Preview: https://notriddle.com/rustdoc-html-demo-12/stringdex-002/std/index.html
bors added a commit that referenced this pull request Oct 17, 2025
Rollup of 6 pull requests

Successful merges:

 - #144936 (CFI: Fix types that implement Fn, FnMut, or FnOnce)
 - #147468 (Implement fs api set_times and set_times_nofollow)
 - #147660 (rustdoc-search: stringdex 0.0.2)
 - #147735 (Micro-optimization in `FunctionCx::initialize_locals`)
 - #147764 (Undo CopyForDeref assertion in const qualif)
 - #147783 (bootstrap: migrate to object 0.37)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Oct 17, 2025

⌛ Testing commit fdeb363 with merge f464759...

@bors
Copy link
Collaborator

bors commented Oct 17, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing f464759 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 17, 2025
@bors bors merged commit f464759 into rust-lang:master Oct 17, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 17, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a41214f (parent) -> f464759 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f46475914de626785090a05ae037578aaa119fc8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 10882.4s -> 8134.7s (-25.2%)
  2. x86_64-gnu-tools: 2974.1s -> 3413.4s (14.8%)
  3. aarch64-gnu-llvm-20-2: 2181.2s -> 2482.4s (13.8%)
  4. x86_64-mingw-1: 10533.3s -> 9307.5s (-11.6%)
  5. dist-ohos-armv7: 4085.8s -> 4488.0s (9.8%)
  6. dist-apple-various: 3348.0s -> 3666.2s (9.5%)
  7. aarch64-msvc-2: 4764.2s -> 5180.3s (8.7%)
  8. i686-msvc-1: 9712.0s -> 10452.1s (7.6%)
  9. dist-i686-msvc: 8313.6s -> 7744.3s (-6.8%)
  10. test-various: 4395.1s -> 4099.6s (-6.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f464759): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-2.5%, -0.2%] 5
Improvements ✅
(secondary)
-1.1% [-5.7%, -0.3%] 9
All ❌✅ (primary) -0.8% [-2.5%, -0.2%] 5

Max RSS (memory usage)

Results (primary -3.1%, secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.1% [-3.1%, -3.1%] 1
Improvements ✅
(secondary)
-2.8% [-4.1%, -1.6%] 2
All ❌✅ (primary) -3.1% [-3.1%, -3.1%] 1

Cycles

Results (primary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.6% [2.6%, 2.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.516s -> 475.372s (-0.24%)
Artifact size: 390.37 MiB -> 390.39 MiB (0.00%)

@rustbot rustbot removed the perf-regression Performance regression. label Oct 17, 2025
@notriddle notriddle deleted the stringdex-002 branch October 17, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants