- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
remove span calls from deprecated attribute checking #147685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | @rustbot author | 
| Reminder, once the PR becomes ready for a review, use  | 
7067a04    to
    43d915c      
    Compare
  
    | @rustbot review | 
              
                    JonathanBrouwer
  
              
              approved these changes
              
                  
                    Oct 14, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me when CI is green
| @bors r+ rollup | 
    
  bors 
      added a commit
      that referenced
      this pull request
    
      Oct 15, 2025 
    
    
      
  
    
      
    
  
Rollup of 7 pull requests Successful merges: - #146841 (Stabilise `rotate_left` and `rotate_right` in `[_]` as `const fn` items.) - #146949 (Add vsx register support for ppc inline asm, and implement preserves_flag option) - #147539 (resolve: Use primitives for conditional mutability more consistently) - #147685 (remove span calls from deprecated attribute checking) - #147699 (Clairify docs for `AttributeKind::DocComment`) - #147706 (Add myself to review rotation) - #147711 (Clarify that UB will occur, not can/may in GlobalAlloc docs) r? `@ghost` `@rustbot` modify labels: rollup
    
  rust-timer 
      added a commit
      that referenced
      this pull request
    
      Oct 15, 2025 
    
    
      
  
    
      
    
  
Rollup merge of #147685 - jdonszelmann:deprecated-no-span, r=JonathanBrouwer remove span calls from deprecated attribute checking r? `@JonathanBrouwer`
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-attributes
  Area: Attributes (`#[…]`, `#![…]`) 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-compiler
  Relevant to the compiler team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
r? @JonathanBrouwer