-
Notifications
You must be signed in to change notification settings - Fork 13.9k
feat(rustdoc): --emit=depinfo output to stdout via -
#147762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit demonstrates that `rustdoc --emit=depinfo=-` hasn't yet supported emitting to stdout.
|
rustbot has assigned @GuillaumeGomez. Use |
--emit=depinfo output to stdout via -
src/librustdoc/config.rs
Outdated
| /// Similar to [`rustc_session::config::OutFileName`] but can't use that | ||
| /// because it doesn't implement `Eq`. | ||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| pub(crate) enum OutFile { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to make rustc's OutFile Eq (and pub if it isn't already) and use it here. We already reuse rustc's Input type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. I wasn't sure whether it is allowed. Thanks :)
rustdoc's `--emit=depinfo` flag now supports using `-` to write the output to stdout.
a835408 to
e7130d3
Compare
|
Thanks! @bors r+ rollup |
…r=fmease feat(rustdoc): `--emit=depinfo` output to stdout via `-` rustdoc's `--emit=depinfo` flag now supports using `-` to write the output to stdout, aligning with rustc's behavior. This will fix <rust-lang#147649>. ### How to review * The first commit demonstrates that `rustdoc --emit=depinfo=-` hasn't yet supported emitting to stdout. * The second implements it and the diff shows how the behavior changes.
Rollup of 4 pull requests Successful merges: - #115501 (Add new inherit_handles flag to CommandExt trait) - #146629 (std: reorganize the UNIX-internal `weak` module) - #147762 (feat(rustdoc): `--emit=depinfo` output to stdout via `-`) - #148001 (fix: Don't add diff symbol to unchanged lines) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #147762 - weihanglo:rustdoc-depinfo-stdout, r=fmease feat(rustdoc): `--emit=depinfo` output to stdout via `-` rustdoc's `--emit=depinfo` flag now supports using `-` to write the output to stdout, aligning with rustc's behavior. This will fix <#147649>. ### How to review * The first commit demonstrates that `rustdoc --emit=depinfo=-` hasn't yet supported emitting to stdout. * The second implements it and the diff shows how the behavior changes.
rustdoc's
--emit=depinfoflag now supports using-to write the output to stdout,aligning with rustc's behavior.
This will fix #147649.
How to review
rustdoc --emit=depinfo=-hasn't yet supported emitting to stdout.