Clippy subtree update #147779

flip1995 · 2025-10-16T14:39:03Z

Cargo.lock update, because clippy_utils is now also using itertools

…rn suggestions

Volatile reads and writes to non-primitive types are not well-defined, and can cause problems. See rust-lang/rust-clippy#15529 for more details.

switch around `*_amount` and `*_expr` -- otherwise the order gets confusing now because of both of them being `Expr`s

this is kind of a side-effect of the next commit

changelog: none Signed-off-by: Zihan <zihanli0822@gmail.com>

…ubtree-update

now lints on ```rs let mut x = [1,2,3].into_iter(); loop { let Some(x) = x.next() else { break }; dbg!(x); } ``` ``` changelog: [`while_let_loop`]: extend to lint on `let else` ```

Volatile reads and writes to non-primitive types are not well-defined, and can cause problems. Fixes rust-lang/rust-clippy#15529 changelog: [`volatile_composites`]: Lint when read/write_volatile is used on composite types (structs, arrays, etc) as their semantics are not well defined.

Remove no-rustfixes where it's not required anymore changelog: none

…avidtwco test: Subtract code_offset from width for ui_testing `annotate-snippets` does not have a "UI test" mode like `rustc`, [where the code offset is not subtracted from the column width](https://github.com/rust-lang/rust/blob/f34ba774c78ea32b7c40598b8ad23e75cdac42a6/compiler/rustc_errors/src/emitter.rs#L1985-L1987). This makes it so `annotate-snippets` will shift the output for some very long tests 5 - 7 columns to the left. As part of my work to have `rustc` use `annotate-snippets`, and to reduce the test differences between the two, I figured it would be best if `rustc` started subtracting the code offset from the width as well. The first commit exists to keep the test output changes of adding a new line to a test separate from adding the `--diagnostic-width` flag in the second commit. This makes it easier to verify that adding the flag does not affect the test's output. [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/147480-t-compiler.2Fdiagnostics/topic/annotate-snippets.20hurdles)

changelog:none

…ang#15816) Fixes rust-lang/rust-clippy#15805 ICE bisects to 9457d64, which handles the span incorrectly when part of the path originates from internal declarative macro. changelog: none

…rn suggestions (rust-lang#15608) Fixes rust-lang/rust-clippy#13287 changelog: [`collapsible_match`]: exclude binding modes from struct field pattern suggestions

Adds a new lint that detects `var = Default::default()` when `var` is `Box<T>` and `T` implements `Default`. changelog: [`replace_box`]: new lint

…-lang#15547) Closes rust-lang/rust-clippy#14550 Closes rust-lang/rust-clippy#15548 changelog: [`needless_continue`] fix FP when match type is not unit or never

flip1995 · 2025-10-16T18:39:19Z

The above issue should be fixed now.

Manishearth · 2025-10-16T18:43:42Z

@bors r+

bors · 2025-10-16T18:43:45Z

📌 Commit 4b0cfb6 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2025-10-16T21:44:24Z

⌛ Testing commit 4b0cfb6 with merge 0d080a5...

Clippy subtree update r? `@Manishearth` `Cargo.lock` update, because `clippy_utils` is now also using `itertools`

rust-log-analyzer · 2025-10-17T00:02:38Z

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


error: test failed, to rerun pass `-p std --test sync`
Bootstrap failed while executing `test --stage 2 --skip=compiler --skip=src`
Build completed unsuccessfully in 2:09:38
make: *** [Makefile:123: ci-mingw-x] Error 1
  local time: Fri Oct 17 00:02:22 CUT 2025
  network time: Fri, 17 Oct 2025 00:02:22 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

bors · 2025-10-17T00:03:14Z

💔 Test failed - checks-actions

samueltardieu · 2025-10-17T05:34:37Z

It looks like the test that made it fail is spuriously failing a lot.

@bors retry

samueltardieu · 2025-10-17T05:43:51Z

(I've open this Zulip thread on the repeated failure of the mingw test)

bors · 2025-10-17T07:57:25Z

⌛ Testing commit 4b0cfb6 with merge a41214f...

bors · 2025-10-17T11:06:05Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing a41214f to master...

github-actions · 2025-10-17T11:08:46Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 28c4c7d (parent) -> a41214f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a41214f9bd7ce869d21898f31107f92c90a9112f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 7696.0s -> 10882.4s (41.4%)
x86_64-gnu-tools: 3661.0s -> 2974.1s (-18.8%)
dist-aarch64-msvc: 6829.8s -> 5807.1s (-15.0%)
pr-check-1: 1709.7s -> 1457.9s (-14.7%)
x86_64-gnu-llvm-20: 2798.2s -> 2426.4s (-13.3%)
aarch64-gnu-llvm-20-2: 2478.9s -> 2181.2s (-12.0%)
x86_64-gnu-gcc: 3432.0s -> 3039.5s (-11.4%)
i686-gnu-2: 6197.8s -> 5616.5s (-9.4%)
aarch64-gnu-llvm-20-1: 3677.7s -> 3359.2s (-8.7%)
dist-apple-various: 3663.8s -> 3348.0s (-8.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-17T12:16:41Z

Finished benchmarking commit (a41214f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.4%, 1.0%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.2%, secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[3.2%, 3.2%]	1
Regressions ❌ (secondary)	4.3%	[4.3%, 4.3%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[-0.8%, 3.2%]	2

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.3s -> 476.516s (0.47%)
Artifact size: 390.30 MiB -> 390.37 MiB (0.02%)

…nishearth Clippy subtree update r? `@Manishearth` `Cargo.lock` update, because `clippy_utils` is now also using `itertools`

ada4a and others added 30 commits September 4, 2025 01:38

misc

d254020

misc: put the : in the right place in the struct field suggestion

a212bd4

fix(collapsible_match): exclude binding modes from struct field patte…

fba062b

…rn suggestions

extend while_let_loop to loop { let else }

d6890e3

Implement volatile_composites lint

1d7c1af

Volatile reads and writes to non-primitive types are not well-defined, and can cause problems. See rust-lang/rust-clippy#15529 for more details.

Add lint unnecessary_option_map_or_else

4c128d9

Add test cases for closure binding and function identity

e410d6f

test: Subtract code_offset from width for ui_testing

6d06db5

fix(zero_repeat_side_effects): don't suggest unsuggestable types

434fe18

misc: extend let-chain

8e3315f

extract the constant codepath

c9ee445

switch around `*_amount` and `*_expr` -- otherwise the order gets confusing now because of both of them being `Expr`s

fix: print actual consts when shifting by them

4423e05

this is kind of a side-effect of the next commit

feat: also detect non-consts

b249f13

legacy_numeric_constants: add ctxt check for internal macro

0ba022a

changelog: none Signed-off-by: Zihan <zihanli0822@gmail.com>

Merge commit '2dc84cb744ad19d187871afb0385a616d80c209d' into clippy-s…

843f4d8

…ubtree-update

extend while_let_loop to loop { let else } (rust-lang#15701)

4f21c99

now lints on ```rs let mut x = [1,2,3].into_iter(); loop { let Some(x) = x.next() else { break }; dbg!(x); } ``` ``` changelog: [`while_let_loop`]: extend to lint on `let else` ```

Remove no-rustfix

f97b493

Remove no-rustfixes (rust-lang#15827)

5b23bd4

Remove no-rustfixes where it's not required anymore changelog: none

Use expect for lint warnings

5318883

Use expect for lint warnings (rust-lang#15625)

f3c020c

changelog:none

legacy_numeric_constants: add ctxt check for internal macro (rust-l…

c1f6124

…ang#15816) Fixes rust-lang/rust-clippy#15805 ICE bisects to 9457d64, which handles the span incorrectly when part of the path originates from internal declarative macro. changelog: none

Add replace_box lint

517ef60

fix(collapsible_match): exclude binding modes from struct field patte…

ea54123

…rn suggestions (rust-lang#15608) Fixes rust-lang/rust-clippy#13287 changelog: [`collapsible_match`]: exclude binding modes from struct field pattern suggestions

Add replace_box lint (rust-lang#14953)

0a2eece

Adds a new lint that detects `var = Default::default()` when `var` is `Box<T>` and `T` implements `Default`. changelog: [`replace_box`]: new lint

Migrate needless_continue to late pass

0415d96

fix: needless_continue FP when match type is not unit or never

7117bd9

fix: needless_continue wrongly unmangled macros

13bd9b5

Fix needless_continue FP when match type is not unit or never (rust…

f110f34

…-lang#15547) Closes rust-lang/rust-clippy#14550 Closes rust-lang/rust-clippy#15548 changelog: [`needless_continue`] fix FP when match type is not unit or never

Update Cargo.lock

4b0cfb6

flip1995 force-pushed the clippy-subtree-update branch from 9895efc to 4b0cfb6 Compare October 16, 2025 18:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2025

bors added a commit that referenced this pull request Oct 16, 2025

Auto merge of #147779 - flip1995:clippy-subtree-update, r=Manishearth

0d080a5

Clippy subtree update r? `@Manishearth` `Cargo.lock` update, because `clippy_utils` is now also using `itertools`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 17, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 17, 2025

bors merged commit a41214f into rust-lang:master Oct 17, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Oct 17, 2025

This was referenced Oct 17, 2025

[WIP] mgca: Add ConstArg representation for const items #139558

Draft

Add new function_casts_as_integer lint #141470

Open

samueltardieu mentioned this pull request Oct 17, 2025

Ignore test-dashboard related files #147806

Open

This was referenced Oct 17, 2025

Limit impl_trait_header query to only trait impls #144607

Merged

Uplifts and extends clippy::needless-maybe-sized into rustc #145924

Open

Clippy subtree update #147779

Clippy subtree update #147779

Uh oh!

Conversation

flip1995 commented Oct 16, 2025

Uh oh!

flip1995 commented Oct 16, 2025

Uh oh!

Manishearth commented Oct 16, 2025

Uh oh!

bors commented Oct 16, 2025

Uh oh!

bors commented Oct 16, 2025

Uh oh!

rust-log-analyzer commented Oct 17, 2025

Uh oh!

bors commented Oct 17, 2025

Uh oh!

samueltardieu commented Oct 17, 2025

Uh oh!

samueltardieu commented Oct 17, 2025

Uh oh!

bors commented Oct 17, 2025

Uh oh!

bors commented Oct 17, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 17, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Oct 17, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

31 participants