Skip to content

Fix invalid jump to def link generated on derive attributes #147990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2025
Merged

Fix invalid jump to def link generated on derive attributes #147990

merged 1 commit into from
Oct 22, 2025
+4 −2

Conversation

@GuillaumeGomez
Copy link
Member

Fixes #147820.

The issue was that we only handled bang macros whereas we should handle all of them.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 22, 2025
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 22, 2025

📌 Commit 21db004 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2025
@jhpratt jhpratt mentioned this pull request Oct 22, 2025
Merged
bors added a commit that referenced this pull request Oct 22, 2025
@bors
Auto merge of #147997 - jhpratt:rollup-nupruru, r=jhpratt
1d23d06 
Rollup of 5 pull requests

Successful merges:

 - #145617 (docs(style): Specify the frontmatter style)
 - #147830 (Reword unstable fingerprints ICE to ask for reproduction)
 - #147988 (Remove unused field `style` from `AttributeKind::CrateName`)
 - #147990 (Fix invalid jump to def link generated on derive attributes)
 - #147991 ([rustdoc] Check `doc(cfg())` even of private/hidden items)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fc0370a into rust-lang:master Oct 22, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 22, 2025
rust-timer added a commit that referenced this pull request Oct 22, 2025
@rust-timer
Unrolled build for #147990
bf569ab 
Rollup merge of #147990 - GuillaumeGomez:fix-derive-link, r=notriddle

Fix invalid jump to def link generated on derive attributes

Fixes #147820.

The issue was that we only handled bang macros whereas we should handle all of them.

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez deleted the fix-derive-link branch October 23, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@notriddle notriddle

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

[rustdoc] --generate-link-to-definition option doesn't work anymore on proc-macro attributes

4 participants

@GuillaumeGomez @notriddle @bors @rustbot