[beta-1.91] Add more context to the temporary lifetime extension FCW #148174

theemathas · 2025-10-27T14:22:44Z

Mention in the FCW that the lifetime extension behavior was wrong since 1.88/1.89.

This was suggested by @cyqsimon in #145838 (comment), with the aim of helping users understand the potential scope of the breakage.

I apologize if this PR is too late in the release process. Feel free to close it if it is.

cc @dianne @cuviper

…mulacrum [beta] Initial cut for 1.91 beta https://forge.rust-lang.org/release/process.html#beta-pr Also backports: - Only run Cranelift dist test on nightly rust-lang#146582 r? `@Mark-Simulacrum`

This reverts commit 095fa86.

…youxu [beta] Revert "compiler: Add Windows resources to rustc-main and rustc_driver" This reverts rust-lang#146018 due to rust-lang#146693

…mulacrum [beta] bump to released stable compiler https://forge.rust-lang.org/release/process.html#beta-stage0-update-friday r? `@Mark-Simulacrum`

…kic" This reverts commit 040a98a, reversing changes made to e8a792d.

…iser Revert "Auto merge of rust-lang#144086 - clubby789:alloc-zeroed, r=nikic" This reverts commit 040a98a, reversing changes made to e8a792d. This reverts rust-lang#144086 on beta due to rust-lang#145995. On master the issue will be fixed by rust-lang#146766.

(cherry picked from commit 4fcafc9)

(cherry picked from commit 83532f8)

(cherry picked from commit 7a0adc0)

(cherry picked from commit 5a4e536)

(cherry picked from commit 5c95f8b)

(cherry picked from commit 1c85a1d)

[beta] backports - remove incorrect fast path rust-lang#146919 - Fix infinite recursion in Path::eq with String rust-lang#146958 - Make #[link="dl"] an FCW rather than an error rust-lang#147262 r? cuviper

(cherry picked from commit e3f1046)

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com> (cherry picked from commit 4787834)

(cherry picked from commit 1589c6c)

When building with `rust.rpath = false`, every `rustc` invocation needs to include the library path as well. I particularly ran into this in `generate_target_spec_json_schema` when testing 1.91-beta in Fedora, where we do disable rpath for our system builds. The new helper function will hopefully encourage the right thing going forward. (cherry picked from commit 03cdcb5)

(cherry picked from commit 95ddfa1)

(cherry picked from commit a3482d9)

[beta] backports - Don't normalize higher-ranked assumptions if they're not used rust-lang#147299 - Fix target list of `link_section` rust-lang#147418 - bootstrap: add `Builder::rustc_cmd` that includes the lib path rust-lang#147419 - Update LLVM to 21.1.2 rust-lang#146953 - Remove the temporary directory when a check ends -- part of rust-lang#147518 r? cuviper

…nglo [beta-1.91] Update cargo submodule 2 commits in 785a383cf715417fcd68c4a98a4523c2d082bb0f..ea2d97820c16195b0ca3fadb4319fe512c199a43 2025-10-04 19:17:20 -0500 to 2025-10-10 15:19:24 -0400 - [beta-1.91] fix: use `host-tuple` for host target subsitution (rust-lang/cargo#16032) - [beta-1.91] fix(timings): compute codegen start time to draw dep lines (rust-lang/cargo#16057) r? ghost

(cherry picked from commit ebd5bea)

(cherry picked from commit 4a4f3b0)

…arts, r=petrochenkov" This reverts commit 99317ef, reversing changes made to 9cd272d. (cherry picked from commit a2b4833)

(cherry picked from commit dd83c57)

(cherry picked from commit a81ed52)

This reverts commit 066023e. (cherry picked from commit c01682e)

…th multi byte chars The issue cannot be reproduced with the former testcase of creating external crates because rust refuses to use "external crate 28_找出字符串中第一个匹配项的下标" because it is not a valid indentifier (starts with number, and contain non ascii chars) But still using 28_找出字符串中第一个匹配项的下标.rs as a filename is accepted by previous rustc releases So we consider it valid, and add an integration test for it to catch any regression on other code related to non ascii filenames. (cherry picked from commit c6acffe)

[beta] backports - Revert constification of `AsRef for Cow` due to inference failure rust-lang#148011 - Revert constification of `Borrow` and `Deref for Cow` due to inference failure rust-lang#148016 - Revert "fix: Filter suggestion parts that match existing code" rust-lang#148043 - Revert "feat: implement `hash_map!` macro" rust-lang#148049 - fix panic when rustc tries to reduce intermediate filenames len with utf8 rust-lang#148018 r? cuviper

rustbot · 2025-10-27T14:22:49Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_borrowck/src/diagnostics/mod.rs

Mention in the FCW that the lifetime extension behavior was wrong since 1.88/1.89.

bors · 2025-10-27T16:00:08Z

☔ The latest upstream changes (presumably #142712) made this pull request unmergeable. Please resolve the merge conflicts.

apiraino · 2025-10-27T16:00:35Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

cuviper · 2025-10-27T16:01:40Z

I just moved the branches, but I can pull this into the stable PR.

fmease · 2025-10-27T19:59:40Z

Channel promotion happened. Contained in / superseded by #148179. Closing.

[stable] Prepare Rust 1.91.0 release - [beta-1.91] Add more context to the temporary lifetime extension FCW #148174 - rustdoc-search: JavaScript optimization based on Firefox Profiler output #146484 - rustdoc-search: use the same ID for entry and path to same item #147045 - rustdoc-search: stringdex update with more packing #147002 - rustdoc-search: stringdex 0.0.2 #147660 - [beta] Clippy beta backport #148029 - 1.91.0 release notes #148013 r? cuviper

Mark-Simulacrum and others added 30 commits September 14, 2025 14:43

Update CURRENT_RUSTC_VERSION post-bump

03265b4

Set channel to beta

9c650ea

Only run Cranelift dist test on nightly

8499d50

Auto merge of rust-lang#146545 - Mark-Simulacrum:beta-next, r=Mark-Si…

1bffa23

…mulacrum [beta] Initial cut for 1.91 beta https://forge.rust-lang.org/release/process.html#beta-pr Also backports: - Only run Cranelift dist test on nightly rust-lang#146582 r? `@Mark-Simulacrum`

Revert "compiler: Add Windows resources to rustc-main and rustc_driver"

6347e7f

This reverts commit 095fa86.

Auto merge of rust-lang#146687 - lambdageek:revert-rc-for-beta, r=jie…

b34cfaf

…youxu [beta] Revert "compiler: Add Windows resources to rustc-main and rustc_driver" This reverts rust-lang#146018 due to rust-lang#146693

Bump to released stable compiler on beta branch

af93ed5

Auto merge of rust-lang#146815 - Mark-Simulacrum:beta-next, r=Mark-Si…

bb624dc

…mulacrum [beta] bump to released stable compiler https://forge.rust-lang.org/release/process.html#beta-stage0-update-friday r? `@Mark-Simulacrum`

Revert "Auto merge of rust-lang#144086 - clubby789:alloc-zeroed, r=ni…

186d91d

…kic" This reverts commit 040a98a, reversing changes made to e8a792d.

add positive and negative tests for temporary scope shortening FCW

f1fbf1f

yeet fastpath

b664386

(cherry picked from commit 4fcafc9)

remove test for no_core

dad01bc

(cherry picked from commit 83532f8)

add test

34182f6

(cherry picked from commit 7a0adc0)

Fix infinite recursion in Path::eq with String

6271db5

(cherry picked from commit 5a4e536)

Update cargo submodule from branch rust-1.91.0

61380c4

Add failing regression test for #[link="dl"]

d427837

(cherry picked from commit 5c95f8b)

Make #[link="dl"] a warning rather than an error

0d2b92c

(cherry picked from commit 1c85a1d)

Auto merge of rust-lang#147284 - cuviper:beta-next, r=cuviper

21cd82a

[beta] backports - remove incorrect fast path rust-lang#146919 - Fix infinite recursion in Path::eq with String rust-lang#146958 - Make #[link="dl"] an FCW rather than an error rust-lang#147262 r? cuviper

Don't normalize higher-ranked assumptions if they're not used

91163a9

(cherry picked from commit e3f1046)

Fix target list of link_section

15843ff

Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com> (cherry picked from commit 4787834)

Add regression test for link_section targets

555abc1

(cherry picked from commit 1589c6c)

[beta-1.91] Update cargo submodule

73481bf

Update LLVM to 21.1.2

3f2437c

(cherry picked from commit 95ddfa1)

Remove the temporary directory when a check ends

5bef436

(cherry picked from commit a3482d9)

warn on future errors from temporary lifetimes shortening in Rust 1.92

6c2246d

add a test for shortening super let binding lifetimes

9f7ad5e

clarfonthey and others added 8 commits October 24, 2025 10:12

Revert inference failure from Deref/Borrow constification

5668098

(cherry picked from commit ebd5bea)

Add regression test for inference failures

21ffe30

(cherry picked from commit 4a4f3b0)

Revert "Auto merge of rust-lang#146121 - Muscraft:filter-suggestion-p…

c956a76

…arts, r=petrochenkov" This reverts commit 99317ef, reversing changes made to 9cd272d. (cherry picked from commit a2b4833)

add crashes tests for overlapping spans

1dda761

(cherry picked from commit dd83c57)

Add a regression test for rust-lang#147971

4bc789b

(cherry picked from commit a81ed52)

Revert "feat: implement hash_map! macro"

912aba6

This reverts commit 066023e. (cherry picked from commit c01682e)

theemathas added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 27, 2025

rustbot assigned BoxyUwU Oct 27, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2025

theemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2025

fmease reviewed Oct 27, 2025

View reviewed changes

compiler/rustc_borrowck/src/diagnostics/mod.rs Outdated Show resolved Hide resolved

[beta-1.91] Add more context to the temporary lifetime extension FCW

6ab240d

Mention in the FCW that the lifetime extension behavior was wrong since 1.88/1.89.

theemathas force-pushed the tle-fcw-more-context branch from 94e8a42 to 6ab240d Compare October 27, 2025 14:51

BoxyUwU approved these changes Oct 27, 2025

View reviewed changes

promote-release bot force-pushed the beta branch from f2f881b to f435972 Compare October 27, 2025 16:00

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 27, 2025

cuviper mentioned this pull request Oct 27, 2025

[stable] Prepare Rust 1.91.0 release #148179

Merged

cuviper added this to the 1.91.0 milestone Oct 27, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2025

fmease closed this Oct 27, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 27, 2025

theemathas deleted the tle-fcw-more-context branch October 28, 2025 00:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[beta-1.91] Add more context to the temporary lifetime extension FCW #148174

[beta-1.91] Add more context to the temporary lifetime extension FCW #148174

Uh oh!

theemathas commented Oct 27, 2025

Uh oh!

rustbot commented Oct 27, 2025

Uh oh!

Uh oh!

bors commented Oct 27, 2025

Uh oh!

apiraino commented Oct 27, 2025

Uh oh!

cuviper commented Oct 27, 2025

Uh oh!

fmease commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

22 participants

[beta-1.91] Add more context to the temporary lifetime extension FCW #148174

[beta-1.91] Add more context to the temporary lifetime extension FCW #148174

Uh oh!

Conversation

theemathas commented Oct 27, 2025

Uh oh!

rustbot commented Oct 27, 2025

Uh oh!

Uh oh!

bors commented Oct 27, 2025

Uh oh!

apiraino commented Oct 27, 2025

Uh oh!

cuviper commented Oct 27, 2025

Uh oh!

fmease commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

22 participants