Skip to content

rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks #148230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks #148230

wants to merge 3 commits into from
+198 −152

Conversation

@fmease
Copy link
Member

@fmease fmease commented Oct 28, 2025

Before After
Screenshot 2025-10-28 at 23-21-02 pre rs - source Screenshot 2025-10-28 at 23-21-51 pre rs - source

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 28, 2025
@fmease fmease force-pushed the rustdoc-highlight-tweaks branch 2 times, most recently from cd8006e to 48cbce8 Compare October 28, 2025 22:48
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease marked this pull request as draft October 28, 2025 23:31
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2025
@fmease fmease force-pushed the rustdoc-highlight-tweaks branch from 48cbce8 to e101aee Compare October 28, 2025 23:56
@fmease fmease marked this pull request as ready for review October 28, 2025 23:56
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@fmease fmease force-pushed the rustdoc-highlight-tweaks branch from e101aee to fdc5323 Compare October 29, 2025 01:13
@fmease fmease force-pushed the rustdoc-highlight-tweaks branch from fdc5323 to 0582085 Compare October 29, 2025 01:49
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Oct 30, 2025

Looks good to me, thanks!

Just waiting for #148213 to be merged first.

@fmease fmease added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmease @rust-log-analyzer @GuillaumeGomez @rustbot