Dogfood trim_{suffix|prefix} in compiler
#148371
Open
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
rustbot
added
A-LLVM
3 tasks
Kivooeo
reviewed
Nov 1, 2025
Comment on lines
2608
to
2615
| let (span, text) = match path.segments.first() { | ||
| Some(seg) if let Some(name) = seg.ident.as_str().strip_prefix("let") => { | ||
| // a special case for #117894 | ||
| let name = name.strip_prefix('_').unwrap_or(name); | ||
| (ident_span, format!("let {name}")) | ||
| } | ||
| _ => (ident_span.shrink_to_lo(), "let ".to_string()), | ||
| let (span, text) = if let Some(seg) = path.segments.first() | ||
| && let Some(name) = seg.ident.as_str().strip_prefix("let") | ||
| { | ||
| // a special case for #117894 | ||
| let name = name.trim_prefix('_'); | ||
| (ident_span, format!("let {name}")) | ||
| } else { | ||
| (ident_span.shrink_to_lo(), "let ".to_string()) | ||
| }; |
There was a problem hiding this comment.
I feel like match is better here in term of readability
There was a problem hiding this comment.
I'm a bit surprised, seemed like a clear win to me, but matter of style and taste obviously. It was a drive-by clean up so reverted it :)
yotamofek
force-pushed
the
pr/dogfood-trim-prefix-suffix
branch
from
eca96ee to
d28dcc7
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
hkBst
approved these changes
Nov 3, 2025
fee1-dead
approved these changes
Nov 4, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 4, 2025
…uffix, r=fee1-dead
Dogfood `trim_{suffix|prefix}` in compiler
cc rust-lang#142312
bors
added a commit
that referenced
this pull request
Nov 4, 2025
Rollup of 5 pull requests Successful merges: - #145314 (Tweak output of missing lifetime on associated type) - #147803 (Add -Zannotate-moves for profiler visibility of move/copy operations (codegen)) - #147925 (Fix tests for big-endian) - #148341 (compiler: Fix a couple issues around cargo feature unification) - #148371 (Dogfood `trim_{suffix|prefix}` in compiler) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #142312