Skip to content

Conversation

@ZhongyaoChen
Copy link
Contributor

@ZhongyaoChen ZhongyaoChen commented Nov 3, 2025

Implement the MCP 932: Promote riscv64a23-unknown-linux-gnu to Tier 2 without host tools.

Closes #148353.

Changes:

  • Update target tier from 3 to 2 in target specification
  • Update platform documentation
  • Add CI/CD support for automatic building and distribution via rustup

r? jieyouxu
cc @davidtwco @Noratrieb

… without host tools

Changes:
- Update target tier from 3 to 2 in target specification
- Update platform documentation
- Add CI/CD support for automatic building and distribution via rustup
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 3, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu jieyouxu added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 9, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Nov 9, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

📌 Commit 1af9b63 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Nov 9, 2025

Actually, this can affect CI duration so
@bors rollup=never

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

⌛ Testing commit 1af9b63 with merge 6647be9...

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 6647be9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2025
@bors bors merged commit 6647be9 into rust-lang:master Nov 9, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 86b95eb (parent) -> 6647be9 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 6647be93640686a2a443a49f15c3390b68c8b5dd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1361.8s -> 1704.2s (+25.1%)
  2. x86_64-gnu-gcc: 2797.5s -> 3423.9s (+22.4%)
  3. aarch64-apple: 8804.5s -> 10622.4s (+20.6%)
  4. i686-gnu-2: 5426.7s -> 6309.2s (+16.3%)
  5. dist-x86_64-apple: 7449.1s -> 8637.5s (+16.0%)
  6. aarch64-gnu-llvm-20-2: 2141.9s -> 2469.6s (+15.3%)
  7. x86_64-gnu-llvm-20: 2491.1s -> 2862.3s (+14.9%)
  8. aarch64-gnu: 6353.0s -> 7252.5s (+14.2%)
  9. aarch64-gnu-llvm-20-1: 3458.8s -> 3894.9s (+12.6%)
  10. x86_64-gnu-llvm-21-1: 3273.3s -> 3664.4s (+11.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6647be9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.643s -> 475.519s (-0.24%)
Artifact size: 391.27 MiB -> 391.32 MiB (0.01%)

makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
…ier2, r=jieyouxu

Implement the MCP 932: Promote riscv64a23-unknown-linux-gnu to Tier 2

Implement the [MCP 932](rust-lang/compiler-team#932): Promote riscv64a23-unknown-linux-gnu to Tier 2 without host tools.

Closes rust-lang#148353.

Changes:
- Update target tier from 3 to 2 in target specification
- Update platform documentation
- Add CI/CD support for automatic building and distribution via rustup

r? jieyouxu
cc `@davidtwco` `@Noratrieb`
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 15, 2025
…-tier2, r=Mark-Simulacrum

Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS

This enables rustup distribution of the rust-std component for the riscv64a23-unknown-linux-gnu target
(Previous PR rust-lang#148435 missed this step.)
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 16, 2025
…-tier2, r=Mark-Simulacrum

Add riscv64a23-unknown-linux-gnu to build-manifest TARGETS

This enables rustup distribution of the rust-std component for the riscv64a23-unknown-linux-gnu target
(Previous PR rust-lang#148435 missed this step.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 932: Promote riscv64a23-unknown-linux-gnu to Tier 2 without host tools

6 participants