Skip to content

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Nov 12, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

JohnTitor and others added 30 commits October 22, 2025 21:11
async functions are disallowed (because `-> impl Trait` is not supported). `const` entry functions are allowed, nonsecure-call functions must be function pointers, which cannot be evaluated during constant evaluation.
epoll: unblock threads when new interest is registered
This updates the rust-version file to 8401398.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 8401398
Filtered ref: 9c097c092eaa8dd786fa7c138a3ecd67b4568d00
Upstream diff: rust-lang/rust@ceb7df7...8401398

This merge was created using https://github.com/rust-lang/josh-sync.
epoll: do proper edge detection inside the epoll system
Co-authored-by: Tomasz Miąsko <tomasz.miasko@gmail.com>
It has been removed 9 months ago, which is more than a few months.
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#146627 Simplify jemalloc setup d537e84520f91c06c14a8bfaad2edd601ff65287 (link)
#147753 Suggest add bounding value for RangeTo 413aa7f6b259bf958ca8cad496721a2c27046b93 (link)
#147832 rustdoc: Don't pass RenderOptions to DocContext ec9c2895532eebe94f2bb1bc668c30bfd6513b3f (link)
#147974 Improve diagnostics for buffer reuse with borrowed referenc… c9ec1aec82cbb2d56f609669c82b8f13c8eb546c (link)
#148080 [rustdoc] Fix invalid jump to def macro link generation d67d57bf91fe81a91d26443cd0d3a88edd8de05a (link)
#148465 Adjust spans into the for loops context before creating t… 8668662c4597ebdcb9eb032d32f6ba6c9307a53f (link)
#148500 Update git index before running diff-index 6248f9d1748e44ec29b00094cbfed0e02b5e5251 (link)
#148531 rustc_target: introduce Abi, Env, Os 3cf8e1a23db8c6b64009a94e8dfb438254693515 (link)
#148536 cmse: add test for async and const functions bf145171dcdc5c96093ebf5038d578ff68a9e610 (link)
#148770 implement feature(c_variadic_naked_functions) 2572272cafc68f9d3cc65df7d16f4d58f8d21ad0 (link)
#148780 fix filecheck typos in tests 3af353df8f9a663897ee7212fe59fae37e519ffe (link)
#148819 Remove specialized warning for removed target 27b63f2acdd2c0d8e0202165d892add73fb408f6 (link)
#148830 miri subtree update 00a683eba523b32e911361745a35fb92397b3190 (link)
#148833 Update rustbook dependencies f6857a0170b21634ea2ecad267fbb75b03131b1c (link)
#148834 fix(rustdoc): Color doctest errors ba8bdd7c06eec5358cc729bbb7241ec84cfc628e (link)
#148841 Remove more #[must_use] from portable-simd 91c202c737b8936ec974aa88336182084f9935af (link)

previous master: 11339a0ef5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0b329f8): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
2.1% [1.1%, 3.5%] 20
Regressions ❌
(secondary)
1.4% [0.2%, 2.8%] 25
Improvements ✅
(primary)
-3.0% [-3.0%, -3.0%] 1
Improvements ✅
(secondary)
-0.4% [-0.5%, -0.2%] 2
All ❌✅ (primary) 1.9% [-3.0%, 3.5%] 21

Max RSS (memory usage)

Results (primary 0.9%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.6% [3.6%, 3.6%] 1
Regressions ❌
(secondary)
1.8% [1.8%, 1.8%] 1
Improvements ✅
(primary)
-1.9% [-1.9%, -1.9%] 1
Improvements ✅
(secondary)
-4.1% [-4.1%, -4.1%] 1
All ❌✅ (primary) 0.9% [-1.9%, 3.6%] 2

Cycles

Results (primary -0.2%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.2% [-2.6%, 2.3%] 2

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-1.1%, -0.0%] 67
Improvements ✅
(secondary)
-0.1% [-0.3%, -0.0%] 22
All ❌✅ (primary) -0.1% [-1.1%, -0.0%] 67

Bootstrap: 476.512s -> 475.302s (-0.25%)
Artifact size: 391.37 MiB -> 391.07 MiB (-0.08%)

@rustbot rustbot added the perf-regression Performance regression. label Nov 12, 2025
@Zalathar

This comment was marked as outdated.

@rust-timer

This comment was marked as outdated.

@rust-timer

This comment was marked as outdated.

@Zalathar
Copy link
Member Author

Oh wait, these are all doc profile regressions.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Kobzol
Copy link
Member

Kobzol commented Nov 12, 2025

@rust-timer build d67d57b

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

None of the obvious candidates have reproduced the doc perf regression, so let's try some others.

@rust-timer build 3cf8e1a

@rust-timer

This comment has been minimized.

@rust-timer

This comment was marked as resolved.

@Zalathar
Copy link
Member Author

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d537e84): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
2.2% [1.1%, 3.5%] 20
Regressions ❌
(secondary)
1.4% [0.2%, 2.8%] 25
Improvements ✅
(primary)
-2.9% [-2.9%, -2.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.9% [-2.9%, 3.5%] 21

Max RSS (memory usage)

Results (primary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.4% [3.4%, 3.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.4% [3.4%, 3.4%] 1

Cycles

Results (primary -2.7%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.7% [-2.7%, -2.7%] 1
Improvements ✅
(secondary)
-2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) -2.7% [-2.7%, -2.7%] 1

Binary size

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Bootstrap: 476.512s -> 475.767s (-0.16%)
Artifact size: 391.37 MiB -> 391.09 MiB (-0.07%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) perf-regression Performance regression. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.