float::min/max: reference NaN bit pattern rules #149475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
tgross35
approved these changes
Nov 30, 2025
Contributor
|
Looks great, thanks @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Nov 30, 2025
Rollup merge of #149475 - RalfJung:min-max-nan, r=tgross35 float::min/max: reference NaN bit pattern rules Also, the "in particular" transition to the signed zero handling was odd, so I rearranged things a bit: first a self-contained description of the semantics, then an explanation of which operations in other standards/libraries this most closely corresponds to. r? `@tgross35`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 5, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#149236 (Clarify edge cases for Barrier::new) - rust-lang/rust#149444 (collapse `constness` query `match` logic) - rust-lang/rust#149475 (float::min/max: reference NaN bit pattern rules) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 5, 2025
float::maximum/minimum: make docs more streamlined This does with `maximum`/`minimum` what rust-lang#149475 did with `max`/`min`: first a self-contained description of the semantics, then comparing with other operations. It also makes the wording consistent with those other functions. Previously we had some of the semantics below the examples for some reason, and we repeated "If one of the arguments is NaN, then NaN is returned"; that has been streamlined as well. r? `@tgross35`
rust-timer
added a commit
that referenced
this pull request
Dec 5, 2025
Rollup merge of #149477 - RalfJung:minimum-maximum, r=tgross35 float::maximum/minimum: make docs more streamlined This does with `maximum`/`minimum` what #149475 did with `max`/`min`: first a self-contained description of the semantics, then comparing with other operations. It also makes the wording consistent with those other functions. Previously we had some of the semantics below the examples for some reason, and we repeated "If one of the arguments is NaN, then NaN is returned"; that has been streamlined as well. r? `@tgross35`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 6, 2025
float::maximum/minimum: make docs more streamlined This does with `maximum`/`minimum` what rust-lang/rust#149475 did with `max`/`min`: first a self-contained description of the semantics, then comparing with other operations. It also makes the wording consistent with those other functions. Previously we had some of the semantics below the examples for some reason, and we repeated "If one of the arguments is NaN, then NaN is returned"; that has been streamlined as well. r? `@tgross35`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, the "in particular" transition to the signed zero handling was odd, so I rearranged things a bit: first a self-contained description of the semantics, then an explanation of which operations in other standards/libraries this most closely corresponds to.
r? @tgross35