Disable native-lib for x check miri #149550
Conversation
rustbot
added
S-waiting-on-review
|
Thanks! The genmc-sys things being built for Miri were super slow. You can r=me once PR CI passes. |
This comment has been minimized.
This comment has been minimized.
|
genmc-sys is off-by-default, this is different. However, I'm not super happy about this as it means the native-lib code doesn't get checked, and sometimes one has to work on that code. Ideally we'd still check it, we'd just skip building the C dependency. libffi-sys has a feature for that since libffi-rs/libffi-rs#166, could we make use of that? capstone-sys has a similar feature. |
Which one? I only see I could disable native-lib just when |
|
capstone-sys has this. Maybe this is not in a release yet? |
|
To be fair, it is fairly rare to work on the native-lib stuff in the Rust repo. So I can live with this as a temporary measure. Comments in the code should make it clear that this is a temporary hack that should be removed once Miri's dependencies can properly suppress building their C dependencies. However, this does mean |
Not that I am aware of. |
This reduces check times for miri from 2m15s to 20s. And reduces check times for miri with --compile-time-deps from 1m50s to 7s. This makes rust-analyzer start a lot faster after switching branches.
bjorn3
force-pushed
the
faster_compile_time_deps
branch
from
73b5ff0 to
b3bf315
Compare
|
Okay, let's do this for now, we can always fine-tune later. @bors r+ rollup |
bors
added
S-waiting-on-bors
…=RalfJung Disable native-lib for x check miri This reduces check times for miri from 2m15s to 20s. And reduces check times for miri with --compile-time-deps from 1m50s to 7s. This makes rust-analyzer start a lot faster after switching branches. r? `@RalfJung`
…=RalfJung Disable native-lib for x check miri This reduces check times for miri from 2m15s to 20s. And reduces check times for miri with --compile-time-deps from 1m50s to 7s. This makes rust-analyzer start a lot faster after switching branches. r? ``@RalfJung``
Rollup of 12 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149147 (Fix unused_assignments false positives from macros) - #149183 (Use `TypingMode::PostAnalysis` in `try_evaluate_const`) - #149456 (std: don't call `current_os_id` from signal handler) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149528 (reword error for invalid range patterns) - #149539 (Additional test for uN::{gather,scatter}_bits) - #149549 (Regression test for system register `ttbr0_el2`) - #149550 (Disable native-lib for x check miri) - #149554 (build-manifest: generate MSI and MINGW arrays from rustc) - #149557 (c-variadic: bpf and spirv do not support c-variadic definitions) - #149569 (Fix mailmap issue) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #149550 - bjorn3:faster_compile_time_deps, r=RalfJung Disable native-lib for x check miri This reduces check times for miri from 2m15s to 20s. And reduces check times for miri with --compile-time-deps from 1m50s to 7s. This makes rust-analyzer start a lot faster after switching branches. r? ```@RalfJung```
6 participants
This reduces check times for miri from 2m15s to 20s. And reduces check times for miri with --compile-time-deps from 1m50s to 7s. This makes rust-analyzer start a lot faster after switching branches.
r? @RalfJung