Motor OS: fix compile error #149579
Merged
Motor OS: fix compile error #149579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PR 148765](rust-lang#148765) changed the expected signature of Thread::new(), which broke Motor OS target. Also set thread name.
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
The CI failure seems spurious... @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 3, 2025
Motor OS: fix compile error [PR 148765](rust-lang#148765) changed the expected signature of Thread::new(), which broke Motor OS target. Also set thread name while at it.
bors
added a commit
that referenced
this pull request
Dec 3, 2025
Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 9 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149517 (Implement blessing for tidy alphabetical check) - #149521 (Improve `io::Error::downcast`) - #149545 (fix the check for which expressions read never type) - #149549 (Regression test for system register `ttbr0_el2`) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 10 pull requests Successful merges: - #149521 (Improve `io::Error::downcast`) - #149544 (Only apply `no_mangle_const_items`'s suggestion to plain const items) - #149545 (fix the check for which expressions read never type) - #149570 (rename cortex-ar references to unified aarch32) - #149574 (Batched compiletest Config fixups) - #149579 (Motor OS: fix compile error) - #149595 (Tidying up `tests/ui/issues` tests [2/N]) - #149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") - #149608 (Allow PowerPC spe_acc as clobber-only register) - #149610 (Implement benchmarks for uN::{gather,scatter}_bits) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/compiler-builtins
that referenced
this pull request
Dec 11, 2025
Rollup of 10 pull requests Successful merges: - rust-lang/rust#149521 (Improve `io::Error::downcast`) - rust-lang/rust#149544 (Only apply `no_mangle_const_items`'s suggestion to plain const items) - rust-lang/rust#149545 (fix the check for which expressions read never type) - rust-lang/rust#149570 (rename cortex-ar references to unified aarch32) - rust-lang/rust#149574 (Batched compiletest Config fixups) - rust-lang/rust#149579 (Motor OS: fix compile error) - rust-lang/rust#149595 (Tidying up `tests/ui/issues` tests [2/N]) - rust-lang/rust#149597 (Revert "implement and test `Iterator::{exactly_one, collect_array}`") - rust-lang/rust#149608 (Allow PowerPC spe_acc as clobber-only register) - rust-lang/rust#149610 (Implement benchmarks for uN::{gather,scatter}_bits) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 148765 changed the expected signature of Thread::new(), which broke Motor OS target.
Also set thread name while at it.