Skip to content

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 3, 2025

After #149444 this function became obsolete

r? @fee1-dead

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to constck

cc @fee1-dead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 3, 2025
@rust-log-analyzer

This comment has been minimized.

@oli-obk oli-obk force-pushed the no_is_const_default_method_fn branch from 396cb8b to 0ab78c1 Compare December 3, 2025 12:38
@fmease fmease added the PG-const-traits Project group: Const traits label Dec 3, 2025
@fee1-dead
Copy link
Member

Awesome

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 5, 2025

📌 Commit 0ab78c1 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2025
bors added a commit that referenced this pull request Dec 6, 2025
Rollup of 4 pull requests

Successful merges:

 - #149563 (f*::min/max: fix comparing with libm and IEEE operations)
 - #149592 (`is_const_default_method` is completely handled by the `constness` query)
 - #149662 (Move attribute lints to `rustc_lint`)
 - #149684 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e5f552a into rust-lang:main Dec 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 6, 2025
rust-timer added a commit that referenced this pull request Dec 6, 2025
Rollup merge of #149592 - oli-obk:no_is_const_default_method_fn, r=fee1-dead

`is_const_default_method` is completely handled by the `constness` query

After  #149444 this function became obsolete

r? `@fee1-dead`
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Dec 13, 2025
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#149563 (f*::min/max: fix comparing with libm and IEEE operations)
 - rust-lang/rust#149592 (`is_const_default_method` is completely handled by the `constness` query)
 - rust-lang/rust#149662 (Move attribute lints to `rustc_lint`)
 - rust-lang/rust#149684 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PG-const-traits Project group: Const traits S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants