add CSE optimization tests for iterating over slice #150065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
nikic
reviewed
Dec 17, 2025
Contributor
Author
|
Thank you for the feedback! I've updated the test from assembly-llvm to codegen-llvm. |
Mark-Simulacrum
requested changes
Jan 2, 2026
| //! Checks function has memory(argmem: read) attribute. | ||
| //! Regression test for <https://github.com/rust-lang/rust/issues/119573>. | ||
| //@ compile-flags: -O | ||
| //@ only-x86_64 |
Member
There was a problem hiding this comment.
Is this still needed given this is an LLVM test now?
Contributor
Author
There was a problem hiding this comment.
You're right, it's no longer needed. I've uploaded a version with it removed.
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Member
|
r=me with commits squashed |
Mark-Simulacrum
added
S-waiting-on-author
is57primenumber
force-pushed
the
add-slice-cse-test
branch
from
882ee93 to
65c1722
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is regression test for issue #119573.
This PR introduces a new regression test to verify a critical optimization known as Common Subexpression Elimination (CSE) is correctly applied during various slice iteration patterns.