tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case #150082
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
fee1-dead
requested changes
Dec 20, 2025
Member
There was a problem hiding this comment.
Could you move the entire test to https://github.com/rust-lang/rust/blob/main/library/coretests/tests/fmt/mod.rs? There is no point in using a UI test here.
rustbot
added
S-waiting-on-author
Enselic
force-pushed
the
hrtb-fn-pointer
branch
from
0cb5f5d to
8825e1f
Compare
rustbot
added
the
T-libs
Member
|
sorry, i was thinking the original UI test should also get merged into our unit tests as a drive-by improvement. if you'd want me to do it later as a followup feel free to r=me also. @bors rollup |
Member
Author
|
Oh, I see. Thanks for clarifying. Let's merge the new test first so regressions are prevented. Then the follow up can be made without time pressure. @bors r=fee1-dead |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 21, 2025
tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case Closes rust-lang#50280 which just **E-needs-test**. See rust-lang#50280 (comment) for a bisect of the fix. The issue description is quite vague, so in the test I am linking directly to the most descriptive comment rust-lang#50280 (comment).
bors
added a commit
that referenced
this pull request
Dec 21, 2025
Rollup of 13 pull requests Successful merges: - #146377 (Don't strip shebang in expr-ctxt `include!(…)`) - #149437 (Fix trailing newline in JUnit formatter) - #149658 (tests/assembly-llvm/some-non-zero-from-atomic-optimization.rs: New test) - #149812 (Add const default for OnceCell and OnceLock) - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds) - #150009 (Enable llvm-libunwind by default for Hexagon targets) - #150035 (fix docustring on fetch_or) - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) - #150208 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 21, 2025
tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case Closes rust-lang#50280 which just **E-needs-test**. See rust-lang#50280 (comment) for a bisect of the fix. The issue description is quite vague, so in the test I am linking directly to the most descriptive comment rust-lang#50280 (comment).
bors
added a commit
that referenced
this pull request
Dec 21, 2025
Rollup of 11 pull requests Successful merges: - #146377 (Don't strip shebang in expr-ctxt `include!(…)`) - #149658 (tests/assembly-llvm/some-non-zero-from-atomic-optimization.rs: New test) - #149812 (Add const default for OnceCell and OnceLock) - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds) - #150009 (Enable llvm-libunwind by default for Hexagon targets) - #150035 (fix docustring on fetch_or) - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) r? `@ghost` `@rustbot` modify labels: rollup
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 21, 2025
tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case Closes rust-lang#50280 which just **E-needs-test**. See rust-lang#50280 (comment) for a bisect of the fix. The issue description is quite vague, so in the test I am linking directly to the most descriptive comment rust-lang#50280 (comment).
bors
added a commit
that referenced
this pull request
Dec 21, 2025
…uwer Rollup of 13 pull requests Successful merges: - #146377 (Don't strip shebang in expr-ctxt `include!(…)`) - #149812 (Add const default for OnceCell and OnceLock) - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds) - #150009 (Enable llvm-libunwind by default for Hexagon targets) - #150035 (fix docustring on fetch_or) - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`) - #150185 ([rustdoc] Add missing close tags in extern crate reexports) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) - #150208 (Update books) - #150210 (tests/debuginfo/function-arg-initialization.rs: Stop disabling SingleUseConsts MIR pass) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 21, 2025
tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case Closes rust-lang#50280 which just **E-needs-test**. See rust-lang#50280 (comment) for a bisect of the fix. The issue description is quite vague, so in the test I am linking directly to the most descriptive comment rust-lang#50280 (comment).
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 21, 2025
tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case Closes rust-lang#50280 which just **E-needs-test**. See rust-lang#50280 (comment) for a bisect of the fix. The issue description is quite vague, so in the test I am linking directly to the most descriptive comment rust-lang#50280 (comment).
bors
added a commit
that referenced
this pull request
Dec 21, 2025
Rollup of 11 pull requests Successful merges: - #146377 (Don't strip shebang in expr-ctxt `include!(…)`) - #149812 (Add const default for OnceCell and OnceLock) - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds) - #150009 (Enable llvm-libunwind by default for Hexagon targets) - #150035 (fix docustring on fetch_or) - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`) - #150185 ([rustdoc] Add missing close tags in extern crate reexports) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Dec 22, 2025
Rollup of 11 pull requests Successful merges: - #146377 (Don't strip shebang in expr-ctxt `include!(…)`) - #149812 (Add const default for OnceCell and OnceLock) - #149882 (miri: add -Zbinary-dep-depinfo to dependency builds) - #150009 (Enable llvm-libunwind by default for Hexagon targets) - #150035 (fix docustring on fetch_or) - #150082 (tests/ui/traits/fmt-pointer-trait.rs: Add HRTB fn pointer case) - #150160 (Fix ICE (#149980) for invalid EII in statement position) - #150184 (mir_build: Use the same length type for `TestableCase::Slice` and `TestKind::Len`) - #150185 ([rustdoc] Add missing close tags in extern crate reexports) - #150191 (change non-canonical clone impl to {*self}, fix some doc comments) - #150203 (Drop the From derive macro from the v1 prelude) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50280 which just E-needs-test. See #50280 (comment) for a bisect of the fix.
The issue description is quite vague, so in the test I am linking directly to the most descriptive comment #50280 (comment).