Add PartialEq<Vec<U>> for [T; N]#150140
Closed
Mandalorian7773 wants to merge 1 commit intorust-lang:mainfrom
Closed
Add PartialEq<Vec<U>> for [T; N]#150140Mandalorian7773 wants to merge 1 commit intorust-lang:mainfrom
Mandalorian7773 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
This comment has been minimized.
This comment has been minimized.
This fixes asymmetric equality between arrays and Vecs. Previously `Vec<T> == [T; N]` was supported but `[T; N] == Vec<T]` failed due to a missing impl. The new implementation forwards to slice equality and adds tests to cover the behavior.
This comment has been minimized.
This comment has been minimized.
e50187c to
ca30e04
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
This is a duplicate of #149045 |
Member
|
closing as duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes asymmetric equality between arrays and
Vecs by adding a missingPartialEq<Vec<U>> for [T; N]implementation.Previously, comparisons like
Vec<T> == [T; N]were supported, but the reverse[T; N] == Vec<T>failed due to the absence of a correspondingPartialEqimpl.This PR completes the symmetry by forwarding the comparison to existing slice
equality.
Details
PartialEq<Vec<U>> for [T; N]in the array equality implementation.existing slice equality logic.
Fixes #149017