fix ICE when {{root}} appears in import suggestions#150155
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 22, 2025
Merged
fix ICE when {{root}} appears in import suggestions#150155bors merged 1 commit intorust-lang:mainfrom
bors merged 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Aditya-PS-05
force-pushed
the
fix/ice-150103-root-in-suggestions
branch
from
aee12c6 to
678f581
Compare
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 22, 2025
…n-suggestions, r=estebank
fix ICE when {{root}} appears in import suggestions
Fixes rust-lang#150103
When wrong nested imports like `use A::{::Fish}` were used, the internal {{root}} would appear in diagnostic suggestions, causing an ICE in `join_path_idents` which asserted that **{{root}} should only appear at the start of a path**.
r? `@matthiaskrgr`
This was referenced Dec 22, 2025
rust-timer
added a commit
that referenced
this pull request
Dec 22, 2025
Rollup merge of #150155 - Aditya-PS-05:fix/ice-150103-root-in-suggestions, r=estebank fix ICE when {{root}} appears in import suggestions Fixes #150103 When wrong nested imports like `use A::{::Fish}` were used, the internal {{root}} would appear in diagnostic suggestions, causing an ICE in `join_path_idents` which asserted that **{{root}} should only appear at the start of a path**. r? ``@matthiaskrgr``
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 23, 2025
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#150098 (remove `legacy_const_generic_args` cache) - rust-lang/rust#150155 (fix ICE when {{root}} appears in import suggestions) - rust-lang/rust#150267 (`rust-analyzer` subtree update) - rust-lang/rust#150274 (Fix typo) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 25, 2025
…uwer Rollup of 4 pull requests Successful merges: - rust-lang/rust#150098 (remove `legacy_const_generic_args` cache) - rust-lang/rust#150155 (fix ICE when {{root}} appears in import suggestions) - rust-lang/rust#150267 (`rust-analyzer` subtree update) - rust-lang/rust#150274 (Fix typo) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150103
When wrong nested imports like
use A::{::Fish}were used, the internal {{root}} would appear in diagnostic suggestions, causing an ICE injoin_path_identswhich asserted that {{root}} should only appear at the start of a path.r? @matthiaskrgr