Port #[thread_local] to attribute parser
#150198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Dec 20, 2025
Rollup merge of #150198 - Bryntet:parse_thread_local, r=JonathanBrouwer Port `#[thread_local]` to attribute parser Simple port, only thing that might be an issue is the `help: #[thread_local] can be applied to foreign statics and statics` it probably would be that if an attribute is applicable to both statics and foreign statics that we don't alphabetically sort them next to each other, because now it kinda reads like `#[thread_local]` is something that you primarily use on foreign statics r? `@JonathanBrouwer`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 21, 2025
…uwer Rollup of 2 pull requests Successful merges: - rust-lang/rust#150188 (Dogfood `strip_circumfix`) - rust-lang/rust#150198 (Port `#[thread_local]` to attribute parser) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple port, only thing that might be an issue is the
help: #[thread_local] can be applied to foreign statics and staticsit probably would be that if an attribute is applicable to both statics and foreign statics that we don't alphabetically sort them next to each other, because now it kinda reads like#[thread_local]is something that you primarily use on foreign staticsr? @JonathanBrouwer