Remove unneeded forbid_generic field from Res::SelfTyAlias
#150589
Merged
+27
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
BoxyUwU
approved these changes
Jan 2, 2026
camelid
approved these changes
Jan 2, 2026
The `forbid_generic` field in `Res::SelfTyAlias` is no longer needed. The check for generic `Self` types in anonymous constants is now handled by `check_param_uses_if_mcg` in HIR type lowering, making this field redundant. This removes: - The `forbid_generic` field from `Res::SelfTyAlias` - The hack in `rustc_resolve` that set `forbid_generic: true` when encountering `Self` in constant items - Related pattern matching and field propagation code
AprilNEA
force-pushed
the
remove-unneeded-forbid-generic-field
branch
from
1952b0e to
cc563d5
Compare
Contributor
Author
Clean. |
Member
|
@bors r=camelid,BoxyUwU rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 3, 2026
…neric-field, r=camelid,BoxyUwU Remove unneeded `forbid_generic` field from `Res::SelfTyAlias` Following rust-lang#150519, the `forbid_generic` field in `Res::SelfTyAlias` is no longer needed and can be removed. - Remove the `forbid_generic: bool` field from `Res::SelfTyAlias` - Simplify the ConstantItem rib handling in `rustc_resolve` - no longer need to mutate res to set `forbid_generic: true` - Update all pattern matches and constructors of `SelfTyAlias` Closes rust-lang#150579 r? `@camelid`
This was referenced Jan 3, 2026
bors
added a commit
that referenced
this pull request
Jan 3, 2026
Rollup of 5 pull requests Successful merges: - #150558 (Detect cases where `?` is applied on a type that could be coming from a different crate version than expected) - #150570 (Removed confusing diagnostics note for trait required for `?` operator use) - #150589 (Remove unneeded `forbid_generic` field from `Res::SelfTyAlias`) - #150635 (triagebot: Add a mention for `dec2flt`, `flt2dec`, and `fmt/num.rs`) - #150637 (Fix broken edit links in Unstable and rustc books) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 3, 2026
Rollup merge of #150589 - AprilNEA:remove-unneeded-forbid-generic-field, r=camelid,BoxyUwU Remove unneeded `forbid_generic` field from `Res::SelfTyAlias` Following #150519, the `forbid_generic` field in `Res::SelfTyAlias` is no longer needed and can be removed. - Remove the `forbid_generic: bool` field from `Res::SelfTyAlias` - Simplify the ConstantItem rib handling in `rustc_resolve` - no longer need to mutate res to set `forbid_generic: true` - Update all pattern matches and constructors of `SelfTyAlias` Closes #150579 r? ``@camelid``
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #150519, the
forbid_genericfield inRes::SelfTyAliasis no longer needed and can be removed.forbid_generic: boolfield fromRes::SelfTyAliasrustc_resolve- no longer need to mutate res to setforbid_generic: trueSelfTyAliasCloses #150579
r? @camelid