Skip to content

Conversation

@cyrgani
Copy link
Contributor

@cyrgani cyrgani commented Jan 8, 2026

Per #27747 (comment), these two traits are implementation details and will not be stabilized, so let's hide them from the docs.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 8, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@hanna-kruppe
Copy link
Contributor

The traits will never be stable, but their definition and impls are still important for understanding the signatures (possible element types and corresponding input types) of the stable concat/join methods.

@petertodd
Copy link
Contributor

@hanna-kruppe I didn't actually know about join or concat before, and read the docs for the first time right now. They were a lot easier to understand when I went to the Join/Concat definitions and could see right there what impls there were and what exactly the output type was.

@cyrgani
Copy link
Contributor Author

cyrgani commented Jan 8, 2026

Let's keep them visible then.

@cyrgani cyrgani closed this Jan 8, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2026
@cyrgani cyrgani deleted the hide-join-concat branch January 8, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants