Skip to content

mGCA: Move tests for assoc const bindings (formerly ACE) into dedicated directory & replace more mentions of ACE #150844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 2 commits into from
Jan 12, 2026
Merged

mGCA: Move tests for assoc const bindings (formerly ACE) into dedicated directory & replace more mentions of ACE #150844

rust-bors merged 2 commits into from
Jan 12, 2026

Conversation

@fmease
Copy link
Member

@fmease fmease commented Jan 8, 2026 •
edited
Loading

Split out of PR #150843.
As discussed.

Somewhat obvious underlying principle: If the test checks basic or core parts of assoc const bindings and nothing else, move it, otherwise leave it even if it contains ACEs.

Motivation: It makes a lot easier for me to continue working on ACE efficiently.

r? @BoxyUwU

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 8, 2026
@fmease fmease changed the title Move tests for assoc const bindings (mGCA, fmr. ACE) into dedicated directory & replace more mentions of ACE mGCA: Move tests for assoc const bindings (fmr. ACE) into dedicated directory & replace more mentions of ACE Jan 8, 2026
@fmease fmease changed the title mGCA: Move tests for assoc const bindings (fmr. ACE) into dedicated directory & replace more mentions of ACE mGCA: Move tests for assoc const bindings (formerly ACE) into dedicated directory & replace more mentions of ACE Jan 8, 2026
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 9, 2026

@bors r+ rollup=never

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 9, 2026

📌 Commit b144a11 has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

☀️ Test successful - CI
Approved by: BoxyUwU
Pushing 2f1bd3f to main...

@rust-bors rust-bors bot merged commit 2f1bd3f into rust-lang:main Jan 12, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 12, 2026
@fmease fmease deleted the mv-ace-tests branch January 12, 2026 23:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing aefa104 (parent) -> 2f1bd3f (this PR)

Test differences

Show 106 test diffs

Stage 1

  • [ui] tests/ui/associated-consts/assoc-const-eq-ambiguity.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-bound-var-in-ty-not-wf.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-bound-var-in-ty.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-const_evaluatable_unchecked.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-esc-bound-var-in-ty.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-missing.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-param-in-ty.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-supertraits.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-eq-ty-alias-noninteracting.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const-ty-mismatch.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/assoc-const.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/equality-unused-issue-126729.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/issue-102335-const.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/issue-105330.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/issue-93835.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-consts/projection-unspecified-but-bounded.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-type-bounds/const-projection-err.rs: pass -> [missing] (J1)
  • [ui] tests/ui/associated-type-bounds/issue-99828.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/assoc_const_eq_diagnostic.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/ambiguity.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/assoc-const-ty-mismatch.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/assoc-const.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/bound-var-in-ty-not-wf.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/bound-var-in-ty.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/coexisting-with-type-binding.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/coherence.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/const-bound-to-assoc-ty-99828.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/const-projection-err.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/const_evaluatable_unchecked.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/equality-unused-issue-126729.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/equality_bound_with_infer.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/esc-bound-var-in-ty.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/issue-102335-const.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/issue-105330.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/issue-93835.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/mismatched-types-with-generic-in-ace-no-feature-gate.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/mismatched-types-with-generic-in-ace.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/missing.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/param-in-ty.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/projection-unspecified-but-bounded.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/supertraits.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/unbraced-enum-variant.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/unconstrained_impl_param.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated-const-bindings/using-fnptr-as-type_const.rs: [missing] -> pass (J1)
  • [ui] tests/ui/const-generics/associated_const_equality/coherence.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/associated_const_equality/equality_bound_with_infer.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/associated_const_equality/mismatched-types-with-generic-in-ace-no-feature-gate.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/associated_const_equality/mismatched-types-with-generic-in-ace.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/associated_const_equality/unconstrained_impl_param.rs: pass -> [missing] (J1)
  • [ui] tests/ui/const-generics/mgca/using-fnptr-as-type_const.rs: pass -> [missing] (J1)
  • [ui] tests/ui/generic-const-items/assoc-const-bindings.rs: [missing] -> pass (J1)
  • [ui] tests/ui/generic-const-items/associated-const-equality.rs: pass -> [missing] (J1)

Stage 2

  • [ui] tests/ui/associated-consts/assoc-const-eq-ambiguity.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const-eq-bound-var-in-ty-not-wf.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const-eq-bound-var-in-ty.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const-eq-const_evaluatable_unchecked.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const-eq-esc-bound-var-in-ty.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const-eq-supertraits.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const-eq-ty-alias-noninteracting.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const-ty-mismatch.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/assoc-const.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/equality-unused-issue-126729.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/issue-102335-const.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/issue-105330.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-consts/projection-unspecified-but-bounded.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-type-bounds/const-projection-err.rs: pass -> [missing] (J0)
  • [ui] tests/ui/associated-type-bounds/issue-99828.rs: pass -> [missing] (J0)
  • [ui] tests/ui/const-generics/assoc_const_eq_diagnostic.rs: pass -> [missing] (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/ambiguity.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/assoc-const-ty-mismatch.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/assoc-const.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/bound-var-in-ty-not-wf.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/bound-var-in-ty.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/coexisting-with-type-binding.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/coherence.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/const-bound-to-assoc-ty-99828.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/const-projection-err.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/const_evaluatable_unchecked.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/equality-unused-issue-126729.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/equality_bound_with_infer.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/esc-bound-var-in-ty.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/issue-102335-const.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/issue-105330.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/issue-93835.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/mismatched-types-with-generic-in-ace-no-feature-gate.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/mismatched-types-with-generic-in-ace.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/missing.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/param-in-ty.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/projection-unspecified-but-bounded.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/supertraits.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/unbraced-enum-variant.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/unconstrained_impl_param.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated-const-bindings/using-fnptr-as-type_const.rs: [missing] -> pass (J0)
  • [ui] tests/ui/const-generics/associated_const_equality/coherence.rs: pass -> [missing] (J0)
  • [ui] tests/ui/const-generics/associated_const_equality/equality_bound_with_infer.rs: pass -> [missing] (J0)
  • [ui] tests/ui/const-generics/associated_const_equality/mismatched-types-with-generic-in-ace-no-feature-gate.rs: pass -> [missing] (J0)
  • [ui] tests/ui/const-generics/associated_const_equality/mismatched-types-with-generic-in-ace.rs: pass -> [missing] (J0)
  • [ui] tests/ui/const-generics/associated_const_equality/unconstrained_impl_param.rs: pass -> [missing] (J0)
  • [ui] tests/ui/const-generics/mgca/using-fnptr-as-type_const.rs: pass -> [missing] (J0)
  • [ui] tests/ui/generic-const-items/associated-const-equality.rs: pass -> [missing] (J0)

(and 4 additional test diffs)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2f1bd3f3781c90a8447e37d65a898442b8618895 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 6493.7s -> 10085.9s (+55.3%)
  2. i686-gnu-nopt-2: 8674.8s -> 7584.9s (-12.6%)
  3. test-various: 6874.4s -> 7653.9s (+11.3%)
  4. x86_64-gnu-llvm-21-2: 5282.7s -> 5881.7s (+11.3%)
  5. dist-i586-gnu-i586-i686-musl: 5134.3s -> 5604.9s (+9.2%)
  6. pr-check-2: 2440.6s -> 2651.3s (+8.6%)
  7. dist-ohos-x86_64: 4200.3s -> 4518.5s (+7.6%)
  8. x86_64-msvc-ext1: 8243.7s -> 7677.4s (-6.9%)
  9. dist-riscv64-linux: 4629.2s -> 4930.2s (+6.5%)
  10. aarch64-apple: 11831.7s -> 12590.2s (+6.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Jan 13, 2026
Open
Draft
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 13, 2026

Finished benchmarking commit (2f1bd3f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 4.1% [4.1%, 4.1%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 4.1% [4.1%, 4.1%] 1

Cycles

Results (primary 3.2%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.2% [3.2%, 3.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.371s -> 475.39s (0.21%)
Artifact size: 391.41 MiB -> 391.43 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwU BoxyUwU

Labels

A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@fmease @BoxyUwU @rust-timer @rustbot