std: sys: fs: uefi: Implement File::read #150853
Merged
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
joboet
requested changes
Jan 9, 2026
library/std/src/sys/fs/uefi.rs
Outdated
|
|
||
| let r = unsafe { ((*file_ptr).read)(file_ptr, &mut buf_size, buf.as_mut_ptr().cast()) }; | ||
|
|
||
| if r.is_error() { |
Member
There was a problem hiding this comment.
I think this should be
Suggested change
| if r.is_error() { | |
| if buf_size != 0 && r.is_error() { |
since io::Read requires that
If an error is returned then it must be guaranteed that no bytes were read.
Contributor
Author
There was a problem hiding this comment.
Shouldn't this be if buf_size == 0 && r.is_error(). I think you want to guard against partial reads right?
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
Ayush1325
force-pushed
the
uefi-fs-read
branch
from
cbc8fad to
5725bd1
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Tested using OVMF on QEMU. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Ayush1325
force-pushed
the
uefi-fs-read
branch
from
5725bd1 to
fd59b32
Compare
Member
|
@bors r+ |
rust-bors
bot
added
the
S-waiting-on-bors
Contributor
rust-bors
bot
removed
the
S-waiting-on-review
rust-bors bot
added a commit
that referenced
this pull request
Jan 10, 2026
Rollup of 9 pull requests Successful merges: - #149318 (Implement partial_sort_unstable for slice) - #150805 (Fix ICE in inline always warning emission.) - #150822 (Fix for ICE: eii: fn / macro rules None in find_attr()) - #150853 (std: sys: fs: uefi: Implement File::read) - #150855 (std: sys: fs: uefi: Implement File::tell) - #150881 (Fix std::fs::copy on WASI by setting proper OpenOptions flags) - #150891 (Fix a trivial typo in def_id.rs) - #150892 (Don't check `[mentions]` paths in submodules from tidy) - #150894 (cg_llvm: add a pause to make comment less confusing) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using OVMF on QEMU.
@rustbot label +O-UEFI