Couple of improvements to rustc_fluent_macros#150870
Couple of improvements to rustc_fluent_macros#150870bjorn3 wants to merge 2 commits intorust-lang:mainfrom
Conversation
|
Some changes occurred to the CTFE machinery Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_attr_parsing |
| finish(constants, quote! { include_str!(#relative_ftl_path) }) | ||
| finish( | ||
| constants, | ||
| quote! { include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/", #relative_ftl_path)) }, |
There was a problem hiding this comment.
This is fine with respect to reproducibility, right?
This comment has been minimized.
This comment has been minimized.
feeb3da to
2975c7e
Compare
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
Rust-analyzer doesn't implement this yet, causing it to show an error for pretty much every lib.rs file you have open due to the fluent macro panicking.
This avoids cascading errors as much as possible.
2975c7e to
90c42f0
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
rust-lang/compiler-team#959 would obsolete this PR if it gets accepted. |
|
☔ The latest upstream changes (presumably #151210) made this pull request unmergeable. Please resolve the merge conflicts. |
|
The MCP has been accepted. |
Workaround a feature used by
fluent_messages!that isn't supported by rust-analyzer. And significantly reduce cascading errors when the translation file fails to parse.