Skip to content

Conversation

@joboet
Copy link
Member

@joboet joboet commented Jan 12, 2026

Besides reducing duplication, this also results in formatting parameters like padding, align and fill being respected.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jhpratt
Copy link
Member

jhpratt commented Jan 13, 2026

Procedurally, does this need team approval? This LGTM (r=me), but it is a change of behavior, albeit one that is desirable given that it now follows formatting options.

@joboet
Copy link
Member Author

joboet commented Jan 13, 2026

Don't know, but I suppose asking doesn't hurt...
@rustbot label +I-libs-nominated

@rustbot rustbot added the I-libs-nominated Nominated for discussion during a libs team meeting. label Jan 13, 2026
@the8472
Copy link
Member

the8472 commented Jan 21, 2026

We discussed this during today's T-libs meeting, there weren't any objections.

@the8472 the8472 removed the I-libs-nominated Nominated for discussion during a libs team meeting. label Jan 21, 2026
@joboet
Copy link
Member Author

joboet commented Jan 21, 2026

Alright, thanks! Then I'll
@bors r=@jhpratt

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 21, 2026

📌 Commit d2e8aaa has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 21, 2026
…pratt

std: use `ByteStr`'s `Display` for `OsStr`

Besides reducing duplication, this also results in formatting parameters like padding, align and fill being respected.
rust-bors bot pushed a commit that referenced this pull request Jan 21, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #151010 (std: use `ByteStr`'s `Display` for `OsStr`)
 - #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup)
 - #151219 (Fixed ICE when using function pointer as const generic parameter)
 - #151343 (Port some crate level attrs to the attribute parser)
 - #151463 (add x86_64-unknown-linux-gnuasan to CI)

r? @ghost
@rust-bors rust-bors bot merged commit 76baf2c into rust-lang:main Jan 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 22, 2026
rust-timer added a commit that referenced this pull request Jan 22, 2026
Rollup merge of #151010 - joboet:osstr-bytestr-display, r=jhpratt

std: use `ByteStr`'s `Display` for `OsStr`

Besides reducing duplication, this also results in formatting parameters like padding, align and fill being respected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants