-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
std: use ByteStr's Display for OsStr
#151010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+2
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Member
|
Procedurally, does this need team approval? This LGTM ( |
Member
Author
|
Don't know, but I suppose asking doesn't hurt... |
Member
|
We discussed this during today's T-libs meeting, there weren't any objections. |
Member
Author
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 21, 2026
…pratt std: use `ByteStr`'s `Display` for `OsStr` Besides reducing duplication, this also results in formatting parameters like padding, align and fill being respected.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
…uwer Rollup of 5 pull requests Successful merges: - #151010 (std: use `ByteStr`'s `Display` for `OsStr`) - #151156 (Add GCC and the GCC codegen backend to build-manifest and rustup) - #151219 (Fixed ICE when using function pointer as const generic parameter) - #151343 (Port some crate level attrs to the attribute parser) - #151463 (add x86_64-unknown-linux-gnuasan to CI) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 22, 2026
Rollup merge of #151010 - joboet:osstr-bytestr-display, r=jhpratt std: use `ByteStr`'s `Display` for `OsStr` Besides reducing duplication, this also results in formatting parameters like padding, align and fill being respected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides reducing duplication, this also results in formatting parameters like padding, align and fill being respected.