-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
REPRODUCER: Change thread_local_inner macro transparency to "opaque"
#151022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
Hey, triage here. Could you clarify what the purpose of the PR is? |
|
Hi and thank you for doing PR triaging! The purpose of this PR is to demonstrate to the reviewer of #151046 that that PR non-controversial. I will close this PR once that PR has been merged. (My humble and friendly advice is to not bother doing triaging for draft PRs since they in general are experimental or too early to do review on.) |
compiler: Make Externally Implementable Item (eii) macros "semiopaque" Otherwise eiis defined by std will produce large amounts of `missing stability attribute` errors. This problem is not eii specific, as can be seen in rust-lang#146993 and which is demonstrated in rust-lang#151022. As can be seen with ```console $ git grep rustc_macro_transparency compiler/rustc_arena/src/lib.rs:#[rustc_macro_transparency = "semiopaque"] [...] ``` it is very common for macros to use `"semiopaque"`. r? @jdonszelmann Tracking issue: rust-lang#125418 Needed for: rust-lang#150588
compiler: Make Externally Implementable Item (eii) macros "semiopaque" Otherwise eiis defined by std will produce large amounts of `missing stability attribute` errors. This problem is not eii specific, as can be seen in rust-lang#146993 and which is demonstrated in rust-lang#151022. As can be seen with ```console $ git grep rustc_macro_transparency compiler/rustc_arena/src/lib.rs:#[rustc_macro_transparency = "semiopaque"] [...] ``` it is very common for macros to use `"semiopaque"`. r? @jdonszelmann Tracking issue: rust-lang#125418 Needed for: rust-lang#150588
compiler: Make Externally Implementable Item (eii) macros "semiopaque" Otherwise eiis defined by std will produce large amounts of `missing stability attribute` errors. This problem is not eii specific, as can be seen in rust-lang#146993 and which is demonstrated in rust-lang#151022. As can be seen with ```console $ git grep rustc_macro_transparency compiler/rustc_arena/src/lib.rs:#[rustc_macro_transparency = "semiopaque"] [...] ``` it is very common for macros to use `"semiopaque"`. r? @jdonszelmann Tracking issue: rust-lang#125418 Needed for: rust-lang#150588
compiler: Make Externally Implementable Item (eii) macros "semiopaque" Otherwise eiis defined by std will produce large amounts of `missing stability attribute` errors. This problem is not eii specific, as can be seen in rust-lang#146993 and which is demonstrated in rust-lang#151022. As can be seen with ```console $ git grep rustc_macro_transparency compiler/rustc_arena/src/lib.rs:#[rustc_macro_transparency = "semiopaque"] [...] ``` it is very common for macros to use `"semiopaque"`. r? @jdonszelmann Tracking issue: rust-lang#125418 Needed for: rust-lang#150588
Rollup merge of #151046 - semiopaque-eii-fix, r=jdonszelmann compiler: Make Externally Implementable Item (eii) macros "semiopaque" Otherwise eiis defined by std will produce large amounts of `missing stability attribute` errors. This problem is not eii specific, as can be seen in #146993 and which is demonstrated in #151022. As can be seen with ```console $ git grep rustc_macro_transparency compiler/rustc_arena/src/lib.rs:#[rustc_macro_transparency = "semiopaque"] [...] ``` it is very common for macros to use `"semiopaque"`. r? @jdonszelmann Tracking issue: #125418 Needed for: #150588
compiler: Make Externally Implementable Item (eii) macros "semiopaque" Otherwise eiis defined by std will produce large amounts of `missing stability attribute` errors. This problem is not eii specific, as can be seen in rust-lang/rust#146993 and which is demonstrated in rust-lang/rust#151022. As can be seen with ```console $ git grep rustc_macro_transparency compiler/rustc_arena/src/lib.rs:#[rustc_macro_transparency = "semiopaque"] [...] ``` it is very common for macros to use `"semiopaque"`. r? @jdonszelmann Tracking issue: rust-lang/rust#125418 Needed for: rust-lang/rust#150588
|
no longer needed |
This PR demonstrates that macro transparency
"opaque"triggersmissing stability attributeerrors for other macros in std, not only for Externally Implementable Items (eii) in std. This problem was known before eii. See #146993.This PR has this diff:
and as can be seen below gives build errors like these: