Clean up rustc_attr_parsing

[GuillaumeGomez]

Follow-up of #150934.

It removes the Option<> wrapping for SharedContext::target field and completely removed the target_id field. Considering this type contains a closure and never updates its target_id field, there is no need to keep it around, it can be used directly in the lint emitter.

r? @JonathanBrouwer

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[GuillaumeGomez]

I don't expect any perf change but just in case:

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: fb50715 (fb507154de75738e8d91f27a9e5fad530a7354dc, parent: a6acf0f07f0ed1c12e26dc0db3b9bf1d0504a0bb)

[rust-timer]

Finished benchmarking commit (fb50715): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.2%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.873s -> 473.523s (-0.07%)
Artifact size: 383.59 MiB -> 383.57 MiB (-0.01%)

[JonathanBrouwer]

@bors r+ rollup=never
Rollup=never for perf

[rust-bors]

📌 Commit 8205792 has been approved by JonathanBrouwer

It is now in the queue for this repository.

[rust-bors]

☀️ Test successful - CI
Approved by: JonathanBrouwer
Pushing b08c11d to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c40c51f (parent) -> b08c11d (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b08c11df4b8373905602949a2392123a8aff6bda --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. aarch64-apple: 7730.0s -> 12745.6s (+64.9%)
2. dist-apple-various: 3779.7s -> 4531.4s (+19.9%)
3. x86_64-gnu-nopt: 7827.1s -> 8630.0s (+10.3%)
4. pr-check-1: 1687.2s -> 1528.3s (-9.4%)
5. x86_64-gnu-miri: 4272.7s -> 4664.9s (+9.2%)
6. test-various: 7827.3s -> 7118.9s (-9.0%)
7. x86_64-msvc-ext1: 7493.2s -> 8100.9s (+8.1%)
8. aarch64-gnu-llvm-20-2: 2816.6s -> 3040.4s (+7.9%)
9. dist-x86_64-solaris: 5147.7s -> 5526.5s (+7.4%)
10. i686-gnu-1: 7460.2s -> 7990.2s (+7.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (b08c11d): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.0%	[3.6%, 7.2%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	5.0%	[3.6%, 7.2%]	3

Cycles

Results (primary 3.8%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.8%	[3.8%, 3.8%]	1
Regressions ❌ (secondary)	2.3%	[1.6%, 3.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	3.8%	[3.8%, 3.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.646s -> 475.411s (0.16%)
Artifact size: 383.59 MiB -> 383.60 MiB (0.00%)