Port #[needs_allocator] to attribute parser#151242
Port #[needs_allocator] to attribute parser#151242rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_hir/src/attrs |
|
@bors r+ rollup |
Port #[needs_allocator] to attribute parser Tracking issue: rust-lang#131229 Ports needs_allocator attribute to the new attribute parser. Note: this is a deprecated and feature gated attribute.
Rollup of 9 pull requests Successful merges: - #148769 (Stabilize `alloc_layout_extra`) - #149440 (Remove suggestion from importing unstable items on stable channel) - #150200 (Add title field to `ice.md` issue template) - #150955 (Underscore-prefixed bindings are explicitly allowed to be unused) - #151200 (time: Add saturating arithmetic for `SystemTime`) - #151235 (Change field `bit_width: usize` to `bits: u32` in type info) - #151242 (Port #[needs_allocator] to attribute parser) - #151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only]) - #151279 (remove trailing periods in built-in attribute gate messages) r? @ghost
Rollup of 8 pull requests Successful merges: - #148769 (Stabilize `alloc_layout_extra`) - #150200 (Add title field to `ice.md` issue template) - #150955 (Underscore-prefixed bindings are explicitly allowed to be unused) - #151200 (time: Add saturating arithmetic for `SystemTime`) - #151235 (Change field `bit_width: usize` to `bits: u32` in type info) - #151242 (Port #[needs_allocator] to attribute parser) - #151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only]) - #151279 (remove trailing periods in built-in attribute gate messages) r? @ghost
|
Investigating regression from #151291. This doesn't look that perf sensitive to me, but we had seen regressions on other attribute ports, and there's not many other good candidates in that rollup. @rust-timer build c8dd1fd |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (c8dd1fd): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.5%, secondary 3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.856s -> 473.69s (-0.25%) |
Rollup of 8 pull requests Successful merges: - rust-lang/rust#148769 (Stabilize `alloc_layout_extra`) - rust-lang/rust#150200 (Add title field to `ice.md` issue template) - rust-lang/rust#150955 (Underscore-prefixed bindings are explicitly allowed to be unused) - rust-lang/rust#151200 (time: Add saturating arithmetic for `SystemTime`) - rust-lang/rust#151235 (Change field `bit_width: usize` to `bits: u32` in type info) - rust-lang/rust#151242 (Port #[needs_allocator] to attribute parser) - rust-lang/rust#151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only]) - rust-lang/rust#151279 (remove trailing periods in built-in attribute gate messages) r? @ghost
Rollup of 8 pull requests Successful merges: - rust-lang/rust#148769 (Stabilize `alloc_layout_extra`) - rust-lang/rust#150200 (Add title field to `ice.md` issue template) - rust-lang/rust#150955 (Underscore-prefixed bindings are explicitly allowed to be unused) - rust-lang/rust#151200 (time: Add saturating arithmetic for `SystemTime`) - rust-lang/rust#151235 (Change field `bit_width: usize` to `bits: u32` in type info) - rust-lang/rust#151242 (Port #[needs_allocator] to attribute parser) - rust-lang/rust#151274 (Include a link to `count_ones` in the docs for `uN::count_zeros` [docs only]) - rust-lang/rust#151279 (remove trailing periods in built-in attribute gate messages) r? @ghost
Tracking issue: #131229
Ports needs_allocator attribute to the new attribute parser.
Note: this is a deprecated and feature gated attribute.