Port variance attrs to attr parser. #151428
Merged
+57
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_hir/src/attrs |
rustbot
added
A-attributes
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
Contributor
Author
9 tasks
Contributor
|
There's currently 3 attribute related PRs in the queue so 99% chance this will get kicked out with conflicts, but can't hurt to try. Thanks for all your hard work on the attribute ports! <3 @bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
Rollup of 6 pull requests Successful merges: - #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics) - #151340 (Port `#[patchable_function_entry]` to attr parser) - #151351 (Deduplicate diagnostics for const trait supertraits) - #151424 (missing colon after the compile-flags directive) - #151428 (Port variance attrs to attr parser.) - #151429 (s390x: Support aligned stack datalayout) Failed merges: - #151343 (Port some crate level attrs to the attribute parser) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 21, 2026
Rollup merge of #151428 - attrs3, r=JonathanBrouwer Port variance attrs to attr parser. Tracking issue: #131229 Ports rustc_variance and rustc_variance_of_opaques to be parsed attributes. Info: https://rustc-dev-guide.rust-lang.org/variance.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #131229
Ports rustc_variance and rustc_variance_of_opaques to be parsed attributes.
Info: https://rustc-dev-guide.rust-lang.org/variance.html