Fix autodiff codegen tests #151526
Merged
Fix autodiff codegen tests #151526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
ZuseZ4
force-pushed
the
fix-autodiff-codegen-tests
branch
from
9eca551 to
d787761
Compare
rustbot
added
S-waiting-on-review
wsmoses
reviewed
Jan 26, 2026
| // reduce this test to only match the first lines and the ret instructions. | ||
|
|
||
| // This test combines two features of Enzyme, automatic differentiation and batching. As such, it is | ||
| // especially prone to breakages. I reduced it therefore to a minimal check matches argument/return |
There was a problem hiding this comment.
I don't think it's especially prone to breakages, but it definitely means the IR doens't have a guaranteed stable output (in contrast to functionally equivalent being stable).
Also note Enzyme does have this in MLIR already
Member
|
@rustbot reroll |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
r? @oli-obk |
Collaborator
|
|
oli-obk
approved these changes
Feb 4, 2026
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 4, 2026
… r=oli-obk Fix autodiff codegen tests Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future. r? compiler
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 4, 2026
… r=oli-obk Fix autodiff codegen tests Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future. r? compiler
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 4, 2026
… r=oli-obk Fix autodiff codegen tests Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future. r? compiler
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
…uwer Rollup of 11 pull requests Successful merges: - #150605 (skip codegen for intrinsics with big fallback bodies if backend does not need them) - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries) - #151534 (target: fix destabilising target-spec-json) - #152088 (rustbook/README.md: add missing `)`) - #151526 (Fix autodiff codegen tests) - #151810 (citool: report debuginfo test statistics) - #152065 (Convert to inline diagnostics in `rustc_ty_utils`) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152072 (Convert to inline diagnostics in `rustc_monomorphize`) - #152083 (Fix set_times_nofollow for directory on windows) Failed merges: - #152069 (Convert to inline diagnostics in `rustc_privacy`)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 4, 2026
… r=oli-obk Fix autodiff codegen tests Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future. r? compiler
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 4, 2026
… r=oli-obk Fix autodiff codegen tests Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future. r? compiler
This was referenced Feb 4, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
…uwer Rollup of 12 pull requests Successful merges: - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries) - #151534 (target: fix destabilising target-spec-json) - #152088 (rustbook/README.md: add missing `)`) - #151526 (Fix autodiff codegen tests) - #151810 (citool: report debuginfo test statistics) - #151952 (Revert doc attribute parsing errors to future warnings) - #152065 (Convert to inline diagnostics in `rustc_ty_utils`) - #152066 (Convert to inline diagnostics in `rustc_session`) - #152069 (Convert to inline diagnostics in `rustc_privacy`) - #152072 (Convert to inline diagnostics in `rustc_monomorphize`) - #152083 (Fix set_times_nofollow for directory on windows) - #152102 (Convert to inline diagnostics in all codegen backends) Failed merges: - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`)
rust-timer
added a commit
that referenced
this pull request
Feb 4, 2026
Rollup merge of #151526 - ZuseZ4:fix-autodiff-codegen-tests, r=oli-obk Fix autodiff codegen tests Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future. r? compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing autodiff for release on nightly. Since we haven't been running these tests in CI, they regressed over the last months. These changes fixes this and hopefully make the tests more robust for the future.
r? compiler