Add new byte_value and char_value methods to proc_macro::Literal
#151543
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Amanieu
reviewed
Feb 1, 2026
library/proc_macro/src/lib.rs
Outdated
|
|
||
| /// Returns the unescaped char value if the current literal is a char. | ||
| #[unstable(feature = "proc_macro_value", issue = "136652")] | ||
| pub fn char_value(&self) -> Result<char, ConversionErrorKind> { |
Member
There was a problem hiding this comment.
The name should be consistent with the corresponding constructor.
Suggested change
| pub fn char_value(&self) -> Result<char, ConversionErrorKind> { | |
| pub fn character_value(&self) -> Result<char, ConversionErrorKind> { |
library/proc_macro/src/lib.rs
Outdated
|
|
||
| /// Returns the unescaped char value if the current literal is a char. | ||
| #[unstable(feature = "proc_macro_value", issue = "136652")] | ||
| pub fn byte_value(&self) -> Result<u8, ConversionErrorKind> { |
Member
There was a problem hiding this comment.
Same here.
Suggested change
| pub fn byte_value(&self) -> Result<u8, ConversionErrorKind> { | |
| pub fn byte_character_value(&self) -> Result<u8, ConversionErrorKind> { |
library/proc_macro/src/lib.rs
Outdated
| }) | ||
| } | ||
|
|
||
| /// Returns the unescaped char value if the current literal is a char. |
Member
There was a problem hiding this comment.
Suggested change
| /// Returns the unescaped char value if the current literal is a char. | |
| /// Returns the unescaped character value if the current literal is a byte character literal. |
library/proc_macro/src/lib.rs
Outdated
| }) | ||
| } | ||
|
|
||
| /// Returns the unescaped char value if the current literal is a char. |
Member
There was a problem hiding this comment.
Suggested change
| /// Returns the unescaped char value if the current literal is a char. | |
| /// Returns the unescaped character value if the current literal is a character literal. |
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 1, 2026
…eral-methods, r=Amanieu Add new `byte_value` and `char_value` methods to `proc_macro::Literal` Part of rust-lang#136652. It adds two more methods to get unescaped `u8` and `char` from `proc_macro::Literal`. r? @Amanieu
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b7fb220 (parent) -> 8340622 (this PR) Test differencesShow 1 test diff1 doctest diff were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8340622e14324d0090a6edf42fce44fea3d7824f --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (8340622): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.1%, secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 478.155s -> 472.577s (-1.17%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #136652.
It adds two more methods to get unescaped
u8andcharfromproc_macro::Literal.r? @Amanieu